All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Roese <stefan.roese@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] SPL: do not use fix value for u-boot size
Date: Thu, 23 Aug 2012 10:51:30 +0200	[thread overview]
Message-ID: <5035EF12.4020505@gmail.com> (raw)
In-Reply-To: <1345711214-11969-1-git-send-email-sbabic@denx.de>

On 08/23/2012 10:40 AM, Stefano Babic wrote:
> If an u-boot image is not found, SPL thinks to load a bare
> u-boot.bin image with a maximum size of 200KB.
> Use CONFIG_SYS_MONITOR_LEN instead.
> 
> Signed-off-by: Stefano Babic <sbabic@denx.de>
> CC: Tom Rini <trini@ti.com>
> ---
> 
> Note: this is based on Tom's series
> 	"ARM: SPL: Make more generic, merge DaVinci and OMAP"
> 
> Tested with V2 version on a MX35.
> 
>  common/spl/spl.c |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/common/spl/spl.c b/common/spl/spl.c
> index 7d15460..827ff1c 100644
> --- a/common/spl/spl.c
> +++ b/common/spl/spl.c
> @@ -100,7 +100,11 @@ void spl_parse_image_header(const struct image_header *header)
>  		debug("mkimage signature not found - ih_magic = %x\n",
>  			header->ih_magic);
>  		/* Let's assume U-Boot will not be more than 200 KB */
> +#ifdef CONFIG_SYS_MONITOR_LEN
> +		spl_image.size = CONFIG_SYS_MONITOR_LEN;
> +#else
>  		spl_image.size = 200 * 1024;
> +#endif

Yes, I noticed this 200 KiB setting as well. But it seems that this
".size" variable is not referenced at all. Or am I missing something? If
this is correct, then we should probably remove setting it completely.

What do you think?

Thanks,
Stefan

  reply	other threads:[~2012-08-23  8:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-23  8:40 [U-Boot] [PATCH] SPL: do not use fix value for u-boot size Stefano Babic
2012-08-23  8:51 ` Stefan Roese [this message]
2012-08-23  9:23   ` Stefano Babic
2012-08-23  9:28     ` Stefan Roese
2012-08-23  9:38       ` Stefano Babic
2012-08-23 10:46 ` [U-Boot] [PATCH V2] " Stefano Babic
2012-08-23 11:19   ` Stefan Roese
2012-08-23 22:03   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5035EF12.4020505@gmail.com \
    --to=stefan.roese@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.