From: Paolo Bonzini <pbonzini@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Stefan Weil <weil@mail.berlios.de>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [RFC][PATCH] qemu-timer: Run timers in alarm timer handler
Date: Thu, 23 Aug 2012 13:39:55 +0200 [thread overview]
Message-ID: <5036168B.1000900@redhat.com> (raw)
In-Reply-To: <503612B9.1070601@siemens.com>
Il 23/08/2012 13:23, Jan Kiszka ha scritto:
> No need for this indirection via qemu_notify_event. On Unix, we already
> catch SIGALRM via signalfd (or its emulation) and run the handler
> synchronously. Under Win32, handlers run in separate threads. So we just
> need to grab the global lock around the handler execution.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>
> The Unix side looks safe to me, but I'm not yet 100% confident about
> Win32. This is part of an ongoing effort to create separate alarm
> timers over their own io-threads. A lengthy effort.
Can you expand on this?
The Win32 bits look fine, but it's a bit scary to make the Unix and
Win32 paths so different. It works well until we have a BQL for timers,
but would this complicate shrinking the scope of the BQL?
Paolo
next prev parent reply other threads:[~2012-08-23 11:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-23 11:23 [Qemu-devel] [RFC][PATCH] qemu-timer: Run timers in alarm timer handler Jan Kiszka
2012-08-23 11:39 ` Paolo Bonzini [this message]
2012-08-23 12:10 ` Jan Kiszka
2012-08-23 12:24 ` Paolo Bonzini
2012-08-23 13:01 ` Jan Kiszka
2012-08-23 13:11 ` Paolo Bonzini
2012-08-23 18:09 ` Jan Kiszka
2012-08-24 7:45 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5036168B.1000900@redhat.com \
--to=pbonzini@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
--cc=weil@mail.berlios.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.