All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Edvard Fagerholm <edvard.fagerholm@gmail.com>
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
	Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,
	stable@dpdk.org
Subject: Re: [PATCH v2] cpp: Fix missing extern "C" closing bracket
Date: Fri, 27 Jun 2025 17:16:38 +0200	[thread overview]
Message-ID: <5036333.A7TYtsqqnE@thomas> (raw)
In-Reply-To: <20250624195810.2350988-1-edvard.fagerholm@gmail.com>

24/06/2025 21:58, Edvard Fagerholm:
> RTE_FORCE_INTRINSICS with a C++ compiler causes rte_atomic.h and
> rte_byteorder.h to emit on x86 an extern "C" without a closing
> brace.
> 
> Signed-off-by: Edvard Fagerholm <edvard.fagerholm@gmail.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Added root cause tracking:
Fixes: 719834a6849e ("use C linkage where appropriate in headers")
Cc: stable@dpdk.org

And changed the #endif comments to show the #ifndef condition is negative
with an exclamation mark:
#endif /* !RTE_FORCE_INTRINSICS */

Applied, thanks and welcome!

PS: I see you used AI to code your DPDK app, that's interesting
and we will probably look to improve such tools in a near future.

PS2: Thanks for the mobile games ;)



  reply	other threads:[~2025-06-27 15:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-24 11:12 [PATCH] cpp: Fix missing extern "C" closing bracket Edvard Fagerholm
2025-06-24 13:52 ` Bruce Richardson
2025-06-24 14:17   ` Edvard Fagerholm
2025-06-24 19:58 ` [PATCH v2] " Edvard Fagerholm
2025-06-27 15:16   ` Thomas Monjalon [this message]
2025-06-27 15:48     ` Edvard Fagerholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5036333.A7TYtsqqnE@thomas \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=edvard.fagerholm@gmail.com \
    --cc=konstantin.v.ananyev@yandex.ru \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.