From mboxrd@z Thu Jan  1 00:00:00 1970
Content-Type: multipart/mixed; boundary="===============8176375693058338284=="
MIME-Version: 1.0
From: Denis Kenzior <denkenz@gmail.com>
Subject: Re: [PATCH v2] ussd: Recover idle state in case of response sending
 failure
Date: Thu, 23 Aug 2012 13:03:05 -0500
Message-ID: <50367059.9050406@gmail.com>
In-Reply-To: <1345739265-3080-2-git-send-email-philippe.nunes@linux.intel.com>
List-Id: <ofono.ofono.org>
To: ofono@ofono.org

--===============8176375693058338284==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable

Hi Philippe,

On 08/23/2012 11:27 AM, Philippe Nunes wrote:
> GCF test case 31.8.1.2.3 is rejecting the user response.
> Any subsequent USSD notification are not handled because USSD is always in
> state user-action.
> ---
>   src/ussd.c |   12 ++++++++++++
>   1 file changed, 12 insertions(+)
>
> diff --git a/src/ussd.c b/src/ussd.c
> index 74888b2..21e0164 100644
> --- a/src/ussd.c
> +++ b/src/ussd.c
> @@ -414,6 +414,18 @@ void ofono_ussd_notify(struct ofono_ussd *ussd, int =
status, int dcs,
>   		return;
>   	}
>
> +	if (status =3D=3D OFONO_USSD_STATUS_TERMINATED&&
> +			(ussd->state =3D=3D USSD_STATE_IDLE ||
> +			ussd->state =3D=3D USSD_STATE_USER_ACTION)) {

This check makes no sense, why bother checking for ussd->state =3D=3D =

USSD_STATE_IDLE?

> +		ussd_change_state(ussd, USSD_STATE_IDLE);
> +
> +		if (ussd->pending =3D=3D NULL)
> +			return;
> +
> +		reply =3D __ofono_error_not_supported(ussd->pending);
> +		goto out;
> +	}
> +

I would handle it just like the 'Not Supported' case but with a new =

__ofono_error_network_terminated error reply.  Or perhaps re-use =

__ofono_error_canceled.

>   	if (status =3D=3D OFONO_USSD_STATUS_NOT_SUPPORTED) {
>   		ussd_change_state(ussd, USSD_STATE_IDLE);
>

Regards,
-Denis

--===============8176375693058338284==--