From: Laxman Dewangan <ldewangan@nvidia.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Liam Girdwood <lrg@ti.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Axel Lin <axel.lin@gmail.com>,
Gyungoh Yoo <jack.yoo@maxim-ic.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] max8907: fix use of possibly NULL idata
Date: Thu, 23 Aug 2012 23:39:51 +0530 [thread overview]
Message-ID: <503671EF.40101@nvidia.com> (raw)
In-Reply-To: <5036758F.1030507@wwwdotorg.org>
On Thursday 23 August 2012 11:55 PM, Stephen Warren wrote:
> On 08/23/2012 12:19 PM, Stephen Warren wrote:
> Laxman,
>
> The TPS6586x driver avoids this NULL-dereference issue by simply not
> registering any regulators when idata is NULL. See
> drivers/mfd/tps6586x.c:tps6586x_parse_dt():
>
>> for (i = 0, j = 0; i< num&& j< count; i++) {
>> struct regulator_init_data *reg_idata;
>>
>> if (!tps6586x_matches[i].init_data)
>> continue;
> If I interpreted Mark Brown correctly, this isn't correct; all the
> regulators within the chip should always be registered, just without any
> user-supplied constraints. Assuming I didn't misinterpret Mark, can you
> please fix the TPS6586x driver to always register the regulators, and
> apply the fix below. Could you please check the TPS65911 driver and see
> what the status is there too? Thanks very much!
Sure, I will check it.
next prev parent reply other threads:[~2012-08-23 18:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-23 18:19 [PATCH] max8907: fix use of possibly NULL idata Stephen Warren
2012-08-23 18:25 ` Stephen Warren
2012-08-23 18:09 ` Laxman Dewangan [this message]
2012-08-27 18:22 ` Mark Brown
2012-08-27 16:42 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=503671EF.40101@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jack.yoo@maxim-ic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.