From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Kurt Van Dijck <kurt.van.dijck@eia.be>
Cc: linux-can@vger.kernel.org,
Mahesh.Maharjan-EXT@continental-corporation.com
Subject: Re: loopback problem with BCM, RAW using, Daniele Venzano
Date: Thu, 23 Aug 2012 20:35:45 +0200 [thread overview]
Message-ID: <50367801.30707@hartkopp.net> (raw)
In-Reply-To: <20120822085708.GB420@vandijck-laurijssen.be>
On 22.08.2012 10:57, Kurt Van Dijck wrote:
> Oliver,
>
> I did not follow this thread in depth.
>
> The patch looks minimal, but I doubt its usefullness.
> In a proper designed CAN system, each node uses distinct CAN-ids.
> Therefore, filtering out local traffic can always be accomplished
> with the current filtering (RTR frames are an exception, but are
> irrelevant here).
>
> userspace can test flags (MSG_DONTROUTE) to decide if a received
> frame is from <localhost> or remote.
> So I don't see the problem that you're addressing with this patch.
Hello Kurt,
this was a quick shot.
After thinking a bit more on this idea, this sockopt is something like an
additional filter. But then i needs to have two bits:
- receive rx frames (from the outside)
- receive tx frames (from the local host)
Default is to receive both types of frames ...
Btw. i don't know if this additional sockopt makes it even more complicated
for users or if your suggestion to select the frames after reception in the
userspace is better.
Regards,
Oliver
ps. the CAN FD capable 'candump' now prints the RX/TX info on demand too.
next prev parent reply other threads:[~2012-08-23 18:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-17 10:58 loopback problem with BCM, RAW using, Daniele Venzano Mahesh.Maharjan-EXT
2012-08-17 12:13 ` Oliver Hartkopp
2012-08-22 8:57 ` Kurt Van Dijck
2012-08-23 8:40 ` receiving CAN from remote hosts only Kurt Van Dijck
2012-08-23 18:35 ` Oliver Hartkopp [this message]
2012-08-24 4:47 ` loopback problem with BCM, RAW using, Daniele Venzano Kurt Van Dijck
2012-08-24 4:58 ` Oliver Hartkopp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50367801.30707@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=Mahesh.Maharjan-EXT@continental-corporation.com \
--cc=kurt.van.dijck@eia.be \
--cc=linux-can@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.