From: Eric Blake <eblake@redhat.com>
To: "Benoît Canet" <benoit.canet@gmail.com>
Cc: aliguori@us.ibm.com, stefanha@linux.vnet.ibm.com,
qemu-devel@nongnu.org, pbonzini@redhat.com,
xiawenc@linux.vnet.ibm.com, "Benoît Canet" <benoit@irqsave.net>
Subject: Re: [Qemu-devel] [PATCH V5 2/2] qemu-img: Add json output option to the info command.
Date: Thu, 23 Aug 2012 15:14:51 -0600 [thread overview]
Message-ID: <50369D4B.2060508@redhat.com> (raw)
In-Reply-To: <1345725761-30680-3-git-send-email-benoit@irqsave.net>
[-- Attachment #1: Type: text/plain, Size: 727 bytes --]
On 08/23/2012 06:42 AM, Benoît Canet wrote:
> This option --output=[human|json] make qemu-img info output on
> human or JSON representation at the choice of the user.
>
> +static int img_info(int argc, char **argv)
> +{
> + int c;
> + bool human = false, json = false;
I'm still not convinced why we need two booleans, when one would do. If
we ever add a third output type, it would be better to use an enum (0,
1, 2), rather than three separate bools.
>
> +#undef PRINTH
> +
Where did this come from? Other than that, the rest of the series seems
okay for 1.3 from my viewpoint.
--
Eric Blake eblake@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 620 bytes --]
next prev parent reply other threads:[~2012-08-23 21:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-23 12:42 [Qemu-devel] [PATCH V5 0/2] Add JSON output to qemu-img info Benoît Canet
2012-08-23 12:42 ` [Qemu-devel] [PATCH V5 1/2] qapi: Add SnapshotInfo and ImageInfo Benoît Canet
2012-08-23 12:42 ` [Qemu-devel] [PATCH V5 2/2] qemu-img: Add json output option to the info command Benoît Canet
2012-08-23 21:14 ` Eric Blake [this message]
2012-08-25 7:45 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50369D4B.2060508@redhat.com \
--to=eblake@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=benoit.canet@gmail.com \
--cc=benoit@irqsave.net \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
--cc=xiawenc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.