From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Thu, 23 Aug 2012 14:52:57 -0700 Subject: [U-Boot] [PATCH 3/6] SPL: Port SPL framework to powerpc In-Reply-To: <1345709565-28862-4-git-send-email-sr@denx.de> References: <1345709565-28862-1-git-send-email-sr@denx.de> <1345709565-28862-4-git-send-email-sr@denx.de> Message-ID: <5036A639.1070501@ti.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 08/23/2012 01:12 AM, Stefan Roese wrote: > This patch enables the SPL framework to be used on powerpc platforms > and not only ARM. [snip] > +#ifdef CONFIG_PPC > +static void __noreturn jump_to_image_linux(void *arg) > +{ > + debug("Entering kernel arg pointer: 0x%p\n", arg); > + typedef void (*image_entry_arg_t)(void *, ulong r4, ulong r5, ulong r6, > + ulong r7, ulong r8, ulong r9) > + __attribute__ ((noreturn)); > + image_entry_arg_t image_entry = > + (image_entry_arg_t)spl_image.entry_point; > + > + image_entry(arg, 0, 0, EPAPR_MAGIC, CONFIG_SYS_BOOTMAPSZ, 0, 0); > +} > +#endif /* CONFIG_PPC */ > +#endif /* CONFIG_SPL_OS_BOOT */ This, along with board_init_f make me wonder if we shouldn't have an arch/${ARCH}/lib/spl.c that contains them and make them non-static. Perhaps sharing with the non-SPL code portion as well? -- Tom