From: "H. Peter Anvin" <hpa@zytor.com>
To: Fenghua Yu <fenghua.yu@intel.com>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Asit K Mallick <asit.k.mallick@intel.com>,
Tony Luck <tony.luck@intel.com>,
Arjan Dan De Ven <arjan@linux.intel.com>,
Suresh B Siddha <suresh.b.siddha@intel.com>,
Len Brown <len.brown@intel.com>,
"Srivatssa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>,
Randy Dunlap <rdunlap@xenotime.net>,
Chen Gong <gong.chen@linux.intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-pm <linux-pm@vger.kernel.org>, x86 <x86@kernel.org>
Subject: Re: [PATCH v7 0/12] x86: Arbitrary CPU hot(un)plug support
Date: Thu, 23 Aug 2012 19:51:10 -0700 [thread overview]
Message-ID: <5036EC1E.5030804@zytor.com> (raw)
In-Reply-To: <1345769771-27019-1-git-send-email-fenghua.yu@intel.com>
Hi Fenghua,
This patchset breaks compiling with Xen enabled on 64 bits:
/home/hpa/kernel/tip.x86-hotplug/arch/x86/xen/smp.c: In function
‘cpu_bringup’:
/home/hpa/kernel/tip.x86-hotplug/arch/x86/xen/smp.c:75:2: error: too few
arguments to function ‘smp_store_cpu_info’
In file included from
/home/hpa/kernel/tip.x86-hotplug/include/linux/smp.h:38:0,
from
/home/hpa/kernel/tip.x86-hotplug/include/linux/sched.h:70,
from
/home/hpa/kernel/tip.x86-hotplug/arch/x86/xen/smp.c:15:
/home/hpa/kernel/tip.x86-hotplug/arch/x86/include/asm/smp.h:169:6: note:
declared here
/home/hpa/kernel/tip.x86-hotplug/arch/x86/xen/smp.c: In function
‘xen_smp_prepare_cpus’:
/home/hpa/kernel/tip.x86-hotplug/arch/x86/xen/smp.c:257:2: error: too
few arguments to function ‘smp_store_cpu_info’
In file included from
/home/hpa/kernel/tip.x86-hotplug/include/linux/smp.h:38:0,
from
/home/hpa/kernel/tip.x86-hotplug/include/linux/sched.h:70,
from
/home/hpa/kernel/tip.x86-hotplug/arch/x86/xen/smp.c:15:
/home/hpa/kernel/tip.x86-hotplug/arch/x86/include/asm/smp.h:169:6: note:
declared here
make[4]: *** [arch/x86/xen/smp.o] Error 1
make[3]: *** [arch/x86/xen] Error 2
make[2]: *** [arch/x86] Error 2
make[1]: *** [sub-make] Error 2
make[1]: Leaving directory `/home/hpa/kernel/tip.x86-hotplug'
Could you fix that?
-hpa
prev parent reply other threads:[~2012-08-24 2:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-24 0:55 [PATCH v7 0/12] x86: Arbitrary CPU hot(un)plug support Fenghua Yu
2012-08-24 0:56 ` [PATCH v7 01/12] Documentations/cpu-hotplug.tx, kernel-parameters.txt: Add x86 CPU0 online/offline feature Fenghua Yu
2012-08-24 0:56 ` [PATCH v7 02/12] x86/Kconfig: Add config switch for CPU0 hotplug Fenghua Yu
2012-08-24 9:34 ` Borislav Petkov
2012-08-24 19:53 ` Yu, Fenghua
2012-08-24 0:56 ` [PATCH v7 03/12] x86/topology.c: Support functions for CPU0 online/offline Fenghua Yu
2012-08-24 0:56 ` [PATCH v7 04/12] Don't offline CPU0 if any PIC irq can not be migrated out of it Fenghua Yu
2012-08-24 9:39 ` Borislav Petkov
2012-08-24 0:56 ` [PATCH v7 05/12] Because x86 BIOS requires CPU0 to resume from sleep, suspend or hibernate can't be executed if CPU0 is detected offline. To make suspend or hibernate and further resume succeed, CPU0 must be online Fenghua Yu
2012-08-24 9:42 ` Borislav Petkov
2012-08-24 0:56 ` [PATCH v7 06/12] start_cpu0() is defined in head_64.S for 64-bit. The function sets up stack and jumps to start_secondary() for CPU0 wake up Fenghua Yu
2012-08-24 0:56 ` [PATCH v7 07/12] start_cpu0() is defined in head_32.S for 32-bit. " Fenghua Yu
2012-08-24 9:35 ` Borislav Petkov
2012-08-24 0:56 ` [PATCH v7 08/12] Instead of waiting for STARTUP after INITs, BSP will execute the BIOS boot-strap code which is not a desired behavior for waking up BSP. To avoid the boot-strap code, wake up CPU0 by NMI instead Fenghua Yu
2012-08-24 0:56 ` [PATCH v7 09/12] During CPU0 online, enable x2apic, set_numa_node Fenghua Yu
2012-08-24 0:56 ` [PATCH v7 10/12] Ask the first online CPU to save mtrr instead of asking BSP. BSP could be offline when mtrr_save_state() is called Fenghua Yu
2012-08-24 0:56 ` [PATCH v7 11/12] x86/i387.c: Thread xstate is initialized only on CPU0 once Fenghua Yu
2012-08-24 0:56 ` [PATCH v7 12/12] x86/topology.c: debug CPU0 hotplug Fenghua Yu
2012-08-24 2:51 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5036EC1E.5030804@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=asit.k.mallick@intel.com \
--cc=fenghua.yu@intel.com \
--cc=gong.chen@linux.intel.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rdunlap@xenotime.net \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.