From: Paolo Bonzini <pbonzini@redhat.com>
To: rongqing.li@windriver.com
Cc: qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH 2/2] hub: change hub can_receive() strategy
Date: Fri, 24 Aug 2012 10:20:37 +0200 [thread overview]
Message-ID: <50373955.8020504@redhat.com> (raw)
In-Reply-To: <1345794984-10337-2-git-send-email-rongqing.li@windriver.com>
Il 24/08/2012 09:56, rongqing.li@windriver.com ha scritto:
> Only one hub port's peer can_receive() returns 1, the source
> hub port .can_receive should return 1, to fix the below bug:
>
> The up state NIC can not receive any packets if guest has
> more than two NICs and only one NIC is in down state.
> http://lists.nongnu.org/archive/html/qemu-discuss/2012-08/msg00036.html
>
> This bug is introduced by 52a3cb8(add the support for hub
> own flow control) and 60c07d93 (fix qemu_can_send_packet logic),
> they are tried to fix that usb NIC lost packets by blocking hub
> receive until all port attached this hub can receive since usb
> NIC only can accept one packet at one time, their logic is wrong,
> we should fix it by creating a queue for usb NIC.
A link-down NIC should always return 1 from can_receive (and will drop
the packet). Is that the real bug here?
Paolo
next prev parent reply other threads:[~2012-08-24 8:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-24 7:56 [Qemu-devel] [PATCH 1/2] Usb: create the receive queue for the virtual USB NIC rongqing.li
2012-08-24 7:56 ` [Qemu-devel] [PATCH 2/2] hub: change hub can_receive() strategy rongqing.li
2012-08-24 8:20 ` Paolo Bonzini [this message]
2012-08-24 8:33 ` Rongqing Li
2012-08-24 10:11 ` Stefan Hajnoczi
2012-08-24 12:25 ` [Qemu-devel] [PATCH 1/2] Usb: create the receive queue for the virtual USB NIC Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50373955.8020504@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rongqing.li@windriver.com \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.