All of lore.kernel.org
 help / color / mirror / Atom feed
From: Huang Shijie <b32955@freescale.com>
To: <dedekind1@gmail.com>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
	Huang Shijie <shijie8@gmail.com>,
	linux-mtd@lists.infradead.org, marex.vasut@denx.de,
	kernel@pengutronix.de, shawn.guo@linaro.org,
	Fabio Estevam <festevam@gmail.com>,
	dwmw2@infradead.org
Subject: Re: [PATCH 1/2] nand: nand_bbt: Export nand_update_bbt
Date: Fri, 24 Aug 2012 18:35:12 +0800	[thread overview]
Message-ID: <503758E0.7000408@freescale.com> (raw)
In-Reply-To: <1345790488.2848.252.camel@sauron.fi.intel.com>

于 2012年08月24日 14:41, Artem Bityutskiy 写道:
> The default function seem to do the same as your function does. You
> select where you keep your OOB using chip options, and the default
> function does the right thing, no?
The key issue is that the mx23 should copies the bad block mark into the 
"first byte of the nand page",
while the other chips does do this.

I don't think the default function do the same thing. You see:
   nand_default_block_markbad() --> nand_do_write_oob() --> 
chip->ecc.write_oob() -->gpmi_ecc_write_oob()

The gpmi_ecc_write_oob() does nothing,but return -EPERM.

Huang Shijie

  reply	other threads:[~2012-08-24 10:33 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-28 22:29 [PATCH] nand: Kconfig: Allow MTD_NAND_GPMI_NAND to be built as module Fabio Estevam
2012-07-28 22:29 ` [PATCH 1/2] nand: nand_bbt: Export nand_update_bbt Fabio Estevam
2012-08-23 15:08   ` Artem Bityutskiy
2012-08-23 15:36     ` Huang Shijie
2012-08-24  6:41       ` Artem Bityutskiy
2012-08-24 10:35         ` Huang Shijie [this message]
2012-08-24 10:35           ` Huang Shijie
2012-08-24 22:57           ` Brian Norris
2012-08-26 13:05             ` Huang Shijie
2012-08-27 15:25       ` Artem Bityutskiy
2012-08-28  2:19         ` Huang Shijie
2012-08-28 13:02   ` Artem Bityutskiy
  -- strict thread matches above, loose matches on Subject: below --
2012-07-28 22:30 [PATCH 2/2] nand: Kconfig: Allow MTD_NAND_GPMI_NAND to be built as module Fabio Estevam
2012-07-28 22:30 ` [PATCH 1/2] nand: nand_bbt: Export nand_update_bbt Fabio Estevam
2012-08-14 22:50   ` Fabio Estevam
2012-08-15 12:59     ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=503758E0.7000408@freescale.com \
    --to=b32955@freescale.com \
    --cc=dedekind1@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=fabio.estevam@freescale.com \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marex.vasut@denx.de \
    --cc=shawn.guo@linaro.org \
    --cc=shijie8@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.