From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:48878)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hare@suse.de>) id 1T4rGL-0005nh-GP
	for qemu-devel@nongnu.org; Fri, 24 Aug 2012 06:37:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hare@suse.de>) id 1T4rGK-0007oo-Cf
	for qemu-devel@nongnu.org; Fri, 24 Aug 2012 06:37:13 -0400
Received: from cantor2.suse.de ([195.135.220.15]:56252 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <hare@suse.de>)
	id 1T4rGK-0007ok-6d
	for qemu-devel@nongnu.org; Fri, 24 Aug 2012 06:37:12 -0400
Message-ID: <50375957.7040803@suse.de>
Date: Fri, 24 Aug 2012 12:37:11 +0200
From: Hannes Reinecke <hare@suse.de>
MIME-Version: 1.0
References: <1345755722-25229-1-git-send-email-sw@weilnetz.de>
	<50373BE0.4020203@suse.de> <50373871.9020809@redhat.com>
In-Reply-To: <50373871.9020809@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH for 1.2] megasas: Fix MinGW compiler
 warning caused by illegal type cast
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Stefan Weil <sw@weilnetz.de>, qemu-devel@nongnu.org

On 08/24/2012 10:16 AM, Paolo Bonzini wrote:
> Il 24/08/2012 10:31, Hannes Reinecke ha scritto:
>>
>>> Type casts from pointer to integer values must use uintptr_t
>>> instead of unsigned long. Otherwise the compiler complains on
>>> hosts with sizeof(pointer) !=3D sizeof(long).
>>>
>>> The patch also replace magic number 32 by sizeof(info.serial_number)
>>> which has the same value but is better for code reviews.
>>>
>>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>>
>> Sigh. I never seem to get the hang of typecasting.
>>
>> Acked-by: Hannes Reinecke <hare@suse.de>
>=20
> Nope, this needs to be fixed using the same scheme that you used for SA=
S
> addresses.  Quick before Anthony notices and disables MEGASAS. :)
>=20
Ok, done.

Cheers,

Hannes
--=20
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg
GF: J. Hawn, J. Guild, F. Imend=F6rffer, HRB 16746 (AG N=FCrnberg)