From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60270) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4sbU-0001o5-Rh for qemu-devel@nongnu.org; Fri, 24 Aug 2012 08:03:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T4sbT-0007P7-HS for qemu-devel@nongnu.org; Fri, 24 Aug 2012 08:03:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14053) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4sbT-0007P1-9Z for qemu-devel@nongnu.org; Fri, 24 Aug 2012 08:03:07 -0400 Message-ID: <50376D71.7070909@redhat.com> Date: Fri, 24 Aug 2012 14:02:57 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <20120824094738.GH29273@rox.home.comstyle.com> <50376BEF.5060206@redhat.com> <20120824120053.GQ29273@rox.home.comstyle.com> In-Reply-To: <20120824120053.GQ29273@rox.home.comstyle.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] configure: some fixes for OpenBSD List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Brad Smith Cc: Peter Maydell , qemu-devel@nongnu.org Il 24/08/2012 14:00, Brad Smith ha scritto: >>>>> > >> > OpenBSD's uname works as expected with the -s flag so remove the special >>>>> > >> > handling when determining the target OS. Use arch -s to retrieve the >>>>> > >> > hardware architecture as uname -m will return the meta architecture >>>>> > >> > instead of the hardware architecture (.e.g. macppc vs powerpc). >>> > > I'm afraid I think this patch is moving in the wrong direction. >>> > > Wherever possible we should be using compiler checks like check_define, >>> > > not looking at the output of 'uname' and the like. The former will >>> > > work when cross compiling, and the latter will give the wrong answers. >>> > > In some places we have that kind of 'look at uname/etc' check but >>> > > we should be trying to reduce and eliminate it where possible. >> > >> > Right, we should support GNU triplets and a --host argument, and replace >> > uname checks with pattern matching on the triplet. > That still requires a means of generating that triplet in the first place. That's what GNU config.guess is for, but it is only used in the non-cross-compilation case. QEMU's homegrown configure hardly distinguishes between native and cross builds. Paolo