From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ola Lilja Subject: Re: FW: [PATCH 07/22] ASoC: Ux500: Initialise PCM from MSP probe rather than as a device Date: Fri, 24 Aug 2012 15:05:17 +0200 Message-ID: <50377C0D.2060905@stericsson.com> References: <014401cd8165$99960c40$ccc224c0$@se> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from eu1sys200aog120.obsmtp.com (eu1sys200aog120.obsmtp.com [207.126.144.149]) by alsa0.perex.cz (Postfix) with ESMTP id EB2F6265D72 for ; Fri, 24 Aug 2012 15:05:50 +0200 (CEST) In-Reply-To: <014401cd8165$99960c40$ccc224c0$@se> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Mark Brown , lee.jones@linaro.org Cc: roger.xr.nilsson@stericsson.com, "alsa-devel@alsa-project.org" , Linus Walleij , linux-arm-kernel@lists.infradead.org List-Id: alsa-devel@alsa-project.org T24gMDgvMjMvMjAxMiAwOToyOSBQTSwgT2xhIExpbGphIHdyb3RlOgoKPiAKPiAKPj4gLS0tLS1P cmlnaW5hbCBNZXNzYWdlLS0tLS0KPj4gRnJvbTogTGVlIEpvbmVzIFttYWlsdG86bGVlLmpvbmVz QGxpbmFyby5vcmddCj4+IFNlbnQ6IGRlbiAyMyBhdWd1c3RpIDIwMTIgMTY6NTkKPj4gVG86IE1h cmsgQnJvd24KPj4gQ2M6IE9sYSBMaWxqYTsgJ0xpbnVzIFdhbGxlaWonOyByb2dlci54ci5uaWxz c29uQHN0ZXJpY3Nzb24uY29tOyBsaW51eC0KPj4gYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQu b3JnOyBhbHNhLWRldmVsQGFsc2EtcHJvamVjdC5vcmcKPj4gU3ViamVjdDogUmU6IFtQQVRDSCAw Ny8yMl0gQVNvQzogVXg1MDA6IEluaXRpYWxpc2UgUENNIGZyb20gTVNQIHByb2JlCj4+IHJhdGhl ciB0aGFuIGFzIGEgZGV2aWNlCj4+IAo+PiBPbiBUaHUsIEF1ZyAyMywgMjAxMiBhdCAwMzozNzo1 N1BNICswMTAwLCBNYXJrIEJyb3duIHdyb3RlOgo+PiA+IE9uIFRodSwgQXVnIDIzLCAyMDEyIGF0 IDAyOjI2OjE5UE0gKzAxMDAsIExlZSBKb25lcyB3cm90ZToKPj4gPgo+PiA+ID4gPiBJIHRoaW5r IE9sYSBpcyBzdWdnZXN0aW5nIHByb2JpbmcgdGhlIERNQSBkcml2ZXIgZnJvbSB0aGUgbWFjaGlu ZQo+PiA+ID4gPiB3aGljaCB3aWxsIGFsc28gd29yayB0aG91Z2ggSSdtIG5vdCAxMDAlIHN1cmUg aWYgSSdtIHBhcnNpbmcgdGhlCj4+ID4gPiA+IGFib3ZlIGNvcnJlY3RseS4gIFRoZSBpc3N1ZSBp biBEVCB0ZXJtcyBpcyB0aGF0IGlmIHRoZSBETUEKPj4gPiA+ID4gY29udHJvbGxlciBpcyBzaGFy ZWQgd2l0aCBhIGJ1bmNoIG9mIG90aGVyIElQcyB0aGVuIGl0IHNob3VsZAo+PiBoYXZlCj4+ID4g PiA+IG9uZSBub2RlIHNoYXJlZCBiZXR3ZWVuIHRoZW0gYWxsIGFuZCBub3QgYSBidW5jaCBvZiBz aGltIG5vZGVzCj4+ID4gPiA+IGluc2VydGVkIGluIHRoZSBtaWRkbGUgd2hpY2ggb25seSBleGlz dHMgZHVlIHRvIHRoZSB3YXkgTGludXgKPj4gaW5zdGFudGlhdGVzIHN0dWZmLgoKCkkgaGF2ZW4n dCBmb2xsb3dlZCBldmVyeXRoaW5nIGluIHRoaXMgZGlzY3Vzc2lvbiwgYnV0IHdoYXQgSSBtZWFu dCBpbiBhbiBlYXJsaWVyCm1haWwgd2FzIHRoYXQgdXNpbmcgdGhlIGRldmljZSBmb3IgcGxhdGZv cm0tREFJIChNU1BfSTJTKSBhbHNvCmFzIHBsYXRmb3JtIGludCB0aGUgREFJLWxpbmsgc3RydWN0 IGlzIG5vdCBhbnl0aGluZyBJIGNhbiBzZWUgZml0IChhcyBpbiB0aGUKcGF0Y2ggTGVlIGZpcnN0 IHN1Ym1pdHRlZCkuCkkgY2FuIHNlZSBhIGZldyBhY2NlcHRhYmxlIHNvbHV0aW9uczoKMSkgVXNl IGl0IGFzIGl0IGlzISAoQSB2aXJ0dWFsIGRldmljZSBmb3IgUENNIGlzIGNyZWF0ZWQgaW4gYXJj aC9hcm0gYW5kIHRoZQpwcm9iZSBpcyBpbnZva2VkIGZyb20gdGhlIG1hY2hpbmUtZHJpdmVyKS4K MikgU2luY2UgdGhlIGFjdHVhbCBwbGF0Zm9ybSBpcyB0aGUgRE1BLWJsb2NrLCBtYXliZSB0aGVy ZSBpcyBzb21lIHdheSBvZiBtYWtpbmcKdGhlIGRldmljZSAibm9uLXZpcnR1YWwiIGJ5IGhhdmlu ZyBzb21lIHN1Yi1kZXZpY2UgaW4gdGhlIERNQS1kcml2ZXIgdGhhdCBpcwppbnN0ZWFkIHRyaWdn ZXJlZCBpbiB0aGUgc2FtZSB3YXkgYXMgaW4gMSkuCjMpIE1vdmUgaXQgdG8gRFQsIGJ1dCBpdCBz ZWVtcyB0aGF0IGl0IGlzIG5vdCBwb3NzaWJsZSB3aGVuIGl0IGlzIG5vdyBhIHZpcnR1YWwKZGV2 aWNlLgoKQW55IG9mIHRoZXNlIHRocmVlIHdvdWxkIGJlIGZpbmUgd2l0aCBtZS4KCj4+ID4KPj4g PiA+IFdoZW4geW91IHNheSAnbWFjaGluZScsIGRvIHlvdSBtZWFuIGZyb20gYXJjaC88YXJjaD4v bWFjaC0qPyBJZiBzbywKPj4gPiA+IEknbSBrZWVuIGZvciB0aGF0IG5vdCB0byBoYXBwZW4uCj4+ ID4KPj4gPiBObywgc291bmQvc29jL3V4NTAwL3Nub3diYWxsLmMgb3Igd2hhdGV2ZXIuICBBdCBs ZWFzdCB0aGF0J3MgbXkKPj4gZ3Vlc3MuCj4+IAo+PiBBaCwgSSBzZWUuIE1heWJlIHRoZSBtb3A1 MDAuYyBmaWxlIHRoZW4uCj4+IAo+PiA+ID4gPiBUaGV5IGluc3RhbnRpYXRlIHRoZSBQQ00gZHJp dmVyIGR5bmFtaWNhbGx5IGZyb20gdGhlIERBSSB3aGVuCj4+IGl0J3MKPj4gPiA+ID4gcHJvYmVk IHdoaWNoIGlzIHByZXR0eSBtdWNoIHdoYXQgeW91J3JlIHBhdGNoIGlzIGRvaW5nLgo+PiA+Cj4+ ID4gPiBTbyB0aGV5IGRvIGl0IGluIHRoZSBzYW1lIHdoeSBJIGhhdmUgd2l0aCB0aGlzIHBhdGNo PyBEbyB5b3Uga25vdwo+PiA+ID4gd2h5IE9sYSBtaWdodCB0aGluayB0aGlzIGlzIGEgYmFkIGlk ZWE/Cj4+ID4KPj4gPiBJJ20gbm90IDEwMCUgc3VyZSwgSSdtIGd1ZXNzaW5nIGl0IG1pZ2h0IGJl IGRvd24gdG8gdGhlIGZhY3QgdGhhdCB5b3UKPj4gPiBlbmQgdXAgd2l0aCBtdWx0aXBsZSBQQ00g ZHJpdmVycy4gIFdlIGNvdWxkIGF2b2lkIHRoYXQgd2l0aAo+PiA+IHJlZmNvdW50aW5nIGJ1dCBu b2JvZHkncyByZWFsbHkgd29ycmllZCBhYm91dCBpdC4KPj4gCj4+IEkgdGhpbmsgSSdsbCB3YWl0 IGZvciBPbGEgdG8gZ2V0IGJhY2ssIGFzIGhlJ3MgdGhlIGV4cGVydCBvbiB0aGlzCj4+IHN0dWZm Lgo+PiAKPj4gSSdsbCBhdHRlbXB0IHRvIHJlLWppZyB0aGUgcGF0Y2gtc2V0LCBhcyB0aGlzIGlz IGEgYmxvY2tlciBhdG0uCj4+IAo+PiAtLQo+PiBMZWUgSm9uZXMKPj4gTGluYXJvIFNULUVyaWNz c29uIExhbmRpbmcgVGVhbSBMZWFkCj4+IExpbmFyby5vcmcg4pSCIE9wZW4gc291cmNlIHNvZnR3 YXJlIGZvciBBUk0gU29DcyBGb2xsb3cgTGluYXJvOiBGYWNlYm9vawo+PiB8IFR3aXR0ZXIgfCBC bG9nCj4gCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K QWxzYS1kZXZlbCBtYWlsaW5nIGxpc3QKQWxzYS1kZXZlbEBhbHNhLXByb2plY3Qub3JnCmh0dHA6 Ly9tYWlsbWFuLmFsc2EtcHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbHNhLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: ola.o.lilja@stericsson.com (Ola Lilja) Date: Fri, 24 Aug 2012 15:05:17 +0200 Subject: FW: [PATCH 07/22] ASoC: Ux500: Initialise PCM from MSP probe rather than as a device In-Reply-To: <014401cd8165$99960c40$ccc224c0$@se> References: <014401cd8165$99960c40$ccc224c0$@se> Message-ID: <50377C0D.2060905@stericsson.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 08/23/2012 09:29 PM, Ola Lilja wrote: > > >> -----Original Message----- >> From: Lee Jones [mailto:lee.jones at linaro.org] >> Sent: den 23 augusti 2012 16:59 >> To: Mark Brown >> Cc: Ola Lilja; 'Linus Walleij'; roger.xr.nilsson at stericsson.com; linux- >> arm-kernel at lists.infradead.org; alsa-devel at alsa-project.org >> Subject: Re: [PATCH 07/22] ASoC: Ux500: Initialise PCM from MSP probe >> rather than as a device >> >> On Thu, Aug 23, 2012 at 03:37:57PM +0100, Mark Brown wrote: >> > On Thu, Aug 23, 2012 at 02:26:19PM +0100, Lee Jones wrote: >> > >> > > > I think Ola is suggesting probing the DMA driver from the machine >> > > > which will also work though I'm not 100% sure if I'm parsing the >> > > > above correctly. The issue in DT terms is that if the DMA >> > > > controller is shared with a bunch of other IPs then it should >> have >> > > > one node shared between them all and not a bunch of shim nodes >> > > > inserted in the middle which only exists due to the way Linux >> instantiates stuff. I haven't followed everything in this discussion, but what I meant in an earlier mail was that using the device for platform-DAI (MSP_I2S) also as platform int the DAI-link struct is not anything I can see fit (as in the patch Lee first submitted). I can see a few acceptable solutions: 1) Use it as it is! (A virtual device for PCM is created in arch/arm and the probe is invoked from the machine-driver). 2) Since the actual platform is the DMA-block, maybe there is some way of making the device "non-virtual" by having some sub-device in the DMA-driver that is instead triggered in the same way as in 1). 3) Move it to DT, but it seems that it is not possible when it is now a virtual device. Any of these three would be fine with me. >> > >> > > When you say 'machine', do you mean from arch//mach-*? If so, >> > > I'm keen for that not to happen. >> > >> > No, sound/soc/ux500/snowball.c or whatever. At least that's my >> guess. >> >> Ah, I see. Maybe the mop500.c file then. >> >> > > > They instantiate the PCM driver dynamically from the DAI when >> it's >> > > > probed which is pretty much what you're patch is doing. >> > >> > > So they do it in the same why I have with this patch? Do you know >> > > why Ola might think this is a bad idea? >> > >> > I'm not 100% sure, I'm guessing it might be down to the fact that you >> > end up with multiple PCM drivers. We could avoid that with >> > refcounting but nobody's really worried about it. >> >> I think I'll wait for Ola to get back, as he's the expert on this >> stuff. >> >> I'll attempt to re-jig the patch-set, as this is a blocker atm. >> >> -- >> Lee Jones >> Linaro ST-Ericsson Landing Team Lead >> Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook >> | Twitter | Blog >