From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1T4xl4-0006bn-8U for mharc-qemu-trivial@gnu.org; Fri, 24 Aug 2012 13:33:22 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47165) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4xl0-0006Pz-Hm for qemu-trivial@nongnu.org; Fri, 24 Aug 2012 13:33:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T4xkz-00054l-1B for qemu-trivial@nongnu.org; Fri, 24 Aug 2012 13:33:18 -0400 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:34547) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4xkr-00053V-DR; Fri, 24 Aug 2012 13:33:09 -0400 Received: from localhost (v220110690675601.yourvserver.net.local [127.0.0.1]) by v220110690675601.yourvserver.net (Postfix) with ESMTP id 81698728002B; Fri, 24 Aug 2012 19:33:07 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at weilnetz.de Received: from v220110690675601.yourvserver.net ([127.0.0.1]) by localhost (v220110690675601.yourvserver.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2FHWw+RT98+3; Fri, 24 Aug 2012 19:33:06 +0200 (CEST) Received: from flocke.weilnetz.de (p5086EC37.dip.t-dialin.net [80.134.236.55]) by v220110690675601.yourvserver.net (Postfix) with ESMTPSA id D4B6F7280028; Fri, 24 Aug 2012 19:33:06 +0200 (CEST) Received: from localhost ([127.0.0.1] ident=stefan) by flocke.weilnetz.de with esmtp (Exim 4.72) (envelope-from ) id 1T4xko-00015z-Gs; Fri, 24 Aug 2012 19:33:06 +0200 Message-ID: <5037BAD2.5060909@weilnetz.de> Date: Fri, 24 Aug 2012 19:33:06 +0200 From: Stefan Weil User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/20120724 Iceowl/1.0b1 Icedove/3.0.11 MIME-Version: 1.0 To: Stefan Hajnoczi References: <1345437900-8001-1-git-send-email-sw@weilnetz.de> <20120824105436.GC10867@stefanha-thinkpad.localdomain> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 78.47.199.172 Cc: qemu-trivial@nongnu.org, Peter Maydell , qemu-devel@nongnu.org, imammedo@redhat.com Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] qemu-common: Declare qemu_irq earlier X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Aug 2012 17:33:20 -0000 Am 24.08.2012 13:56, schrieb Stefan Hajnoczi: > On Fri, Aug 24, 2012 at 12:06 PM, Peter Maydell > wrote: >> On 24 August 2012 11:54, Stefan Hajnoczi wrote: >>> On Mon, Aug 20, 2012 at 06:45:00AM +0200, Stefan Weil wrote: >>>> This allows using qemu_irq in the target specific cpu.h. >>>> >>>> Signed-off-by: Stefan Weil >>>> --- >>>> qemu-common.h | 3 ++- >>>> 1 files changed, 2 insertions(+), 1 deletions(-) >>> >>> I'm not sure if there's a reason why qemu_irq was previously hidden from >>> cpu.h but the code change itself is fine and no one else has commented. >>> >>> Thanks, applied to the trivial patches tree: >>> https://github.com/stefanha/qemu/commits/trivial-patches >> >> Consensus seemed to be that it was better to move qemu_irq >> into hw/irq.h, as discussed in this mail thread: >> http://lists.gnu.org/archive/html/qemu-devel/2012-08/msg03463.html >> rather than just doing a move of the typedef within this header. > > Fine by me. I won't send a pull request with this patch yet. > > Stefan Weil: Are you happy to use the hw/irq.h patch instead of this? > > Stefan Stefan H., that's OK. Cheers, Stefan From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47153) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T4xkx-0006Ps-LP for qemu-devel@nongnu.org; Fri, 24 Aug 2012 13:33:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T4xkr-000541-Jv for qemu-devel@nongnu.org; Fri, 24 Aug 2012 13:33:15 -0400 Message-ID: <5037BAD2.5060909@weilnetz.de> Date: Fri, 24 Aug 2012 19:33:06 +0200 From: Stefan Weil MIME-Version: 1.0 References: <1345437900-8001-1-git-send-email-sw@weilnetz.de> <20120824105436.GC10867@stefanha-thinkpad.localdomain> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] qemu-common: Declare qemu_irq earlier List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-trivial@nongnu.org, Peter Maydell , qemu-devel@nongnu.org, imammedo@redhat.com Am 24.08.2012 13:56, schrieb Stefan Hajnoczi: > On Fri, Aug 24, 2012 at 12:06 PM, Peter Maydell > wrote: >> On 24 August 2012 11:54, Stefan Hajnoczi wrote: >>> On Mon, Aug 20, 2012 at 06:45:00AM +0200, Stefan Weil wrote: >>>> This allows using qemu_irq in the target specific cpu.h. >>>> >>>> Signed-off-by: Stefan Weil >>>> --- >>>> qemu-common.h | 3 ++- >>>> 1 files changed, 2 insertions(+), 1 deletions(-) >>> >>> I'm not sure if there's a reason why qemu_irq was previously hidden from >>> cpu.h but the code change itself is fine and no one else has commented. >>> >>> Thanks, applied to the trivial patches tree: >>> https://github.com/stefanha/qemu/commits/trivial-patches >> >> Consensus seemed to be that it was better to move qemu_irq >> into hw/irq.h, as discussed in this mail thread: >> http://lists.gnu.org/archive/html/qemu-devel/2012-08/msg03463.html >> rather than just doing a move of the typedef within this header. > > Fine by me. I won't send a pull request with this patch yet. > > Stefan Weil: Are you happy to use the hw/irq.h patch instead of this? > > Stefan Stefan H., that's OK. Cheers, Stefan