Re: [Qemu-devel] [PATCH] linux-user: If loading fails, print error as string, not number

["Andreas Färber" <afaerber@suse.de>]

Am 24.08.2012 20:07, schrieb malc:
> On Fri, 24 Aug 2012, Peter Maydell wrote:
> 
>> If the attempt to load the guest executable fails, print the
>> error message as a string, not a number. This requires us to
>> fix a couple of places in loader_exec() where we were returning
>> -1 instead of a valid negative errno.
>>
>> The change allows us to drop the "Unknown binary format" message
>> because the strerror-enhanced message is now a more self-explanatory
>> "Error while loading $guest-binary: Exec format error".
> 
> Double edged sword:
> 
> a. Localized strings that is near impossible to map back to anything
>    useful
> b. Codes whose meaning is overloaded beyond repair
> 
> Sometimes sticking to plain numbers works better.

I ran into the same issue some time ago and was lucky to have pm215 on
#qemu knowing what was causing this. A pure number (or number translated
to E*) is not so telling.

Could the diplomatic solution be to include the number in the error
message? :)

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg