From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v3 0/8] R-Car DU: Support CRC calculation Date: Sat, 05 May 2018 17:06:50 +0300 Message-ID: <5038283.TSNOrsSzts@avalon> References: <20180428205027.18025-1-laurent.pinchart+renesas@ideasonboard.com> <4411331.L07MOrSnxD@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id A845D6E1C4 for ; Sat, 5 May 2018 14:06:37 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: Mauro Carvalho Chehab , Kieran Bingham , dri-devel , "open list:DMA BUFFER SHARING FRAMEWORK" List-Id: dri-devel@lists.freedesktop.org SGkgRGFuaWVsLAoKKENDJ2luZyBNYXVybykKCk9uIFRodXJzZGF5LCAzIE1heSAyMDE4IDE2OjQ1 OjM2IEVFU1QgRGFuaWVsIFZldHRlciB3cm90ZToKPiBPbiBUaHUsIE1heSAzLCAyMDE4IGF0IDI6 MDYgUE0sIExhdXJlbnQgUGluY2hhcnQgd3JvdGU6Cj4gPiBIaSBEYXZlLAo+ID4gCj4gPiBQaW5n ID8KPiAKPiBOb3QgYXdhcmUgb2YgYW55IGNyYyBjb3JlIHdvcmsgZ29pbmcgb24gaW4gZHJtLCBz byBoYXMgbXkgYWNrLgoKVGhhbmsgeW91LgoKPiBXb3JzdCBjYXNlIHdlIGRvIGEgdG9waWMgYnJh bmNoIG9yIHNvbWV0aGluZyBsaWtlIHRoYXQgKHNpbmNlIEkgZ3Vlc3MgeW91J2xsCj4gZG8gYSBw dWxsIHJlcXVlc3QgYW55d2F5IG9uIHRoZSB2NGwgc2lkZSkuCgpUaGF0IHdvdWxkIHVuZm9ydHVu YXRlbHkgbm90IGJlIHBvc3NpYmxlLCBhcyBNYXVybyBjaGVycnktcGlja3MgcGF0Y2hlcyAKaW5z dGVhZCBvZiBtZXJnaW5nIHB1bGwgcmVxdWVzdHMuIEluIHJhcmUgY2FzZXMgSSBjYW4gYXNrIGZv ciBhIHB1bGwtcmVxdWVzdCAKdG8gYmUgbWVyZ2VkIGFzLWlzLCBidXQgaXQncyB0b28gbGF0ZSBp biB0aGlzIGNhc2UgYXMgdGhlIHByZXZpb3VzIHB1bGwgCnJlcXVlc3QgdGhhdCB0aGlzIHNlcmll cyBpcyBiYXNlZCBvbiBoYXMgYmVlbiBjaGVycnktcGlja2VkLCBub3QgbWVyZ2VkLgoKPiBBY2tl ZC1ieTogbWUuCj4gCj4gPiBPbiBTYXR1cmRheSwgMjggQXByaWwgMjAxOCAyMzo1MDoxOSBFRVNU IExhdXJlbnQgUGluY2hhcnQgd3JvdGU6Cj4gPj4gSGVsbG8sCj4gPj4gCj4gPj4gKERhdmUsIHRo ZXJlJ3MgYSByZXF1ZXN0IGZvciB5b3UgYmVsb3cpCj4gPj4gCj4gPj4gVGhpcyBwYXRjaCBzZXJp ZXMgYWRkcyBzdXBwb3J0IGZvciBDUkMgY2FsY3VsYXRpb24gdG8gdGhlIHJjYXItZHUtZHJtCj4g Pj4gZHJpdmVyLgo+ID4+IAo+ID4+IENSQyBjYWxjdWxhdGlvbiBpcyBzdXBwb3J0ZWQgc3RhcnRp bmcgYXQgdGhlIFJlbmVzYXMgUi1DYXIgR2VuMyBTb0NzLCBhcwo+ID4+IGVhcmxpZXIgdmVyc2lv bnMgZG9uJ3QgaGF2ZSB0aGUgbmVjZXNzYXJ5IGhhcmR3YXJlLiBPbiBHZW4zIFNvQ3MsIHRoZSBD UkMKPiA+PiBpcyBjb21wdXRlZCBieSB0aGUgRElTQ09NIG1vZHVsZSBwYXJ0IG9mIHRoZSBWU1At RCBhbmQgVlNQLURMLgo+ID4+IAo+ID4+IFRoZSBESVNDT00gaXMgaW50ZXJmYWNlZCB0byB0aGUg VlNQIHRocm91Z2ggdGhlIFVJRiBnbHVlIGFuZCBhcHBlYXJzIGFzIGEKPiA+PiBWU1AgZW50aXR5 IHdpdGggYSBzaW5rIHBhZCBhbmQgYSBzb3VyY2UgcGFkLgo+ID4+IAo+ID4+IFRoZSBzZXJpZXMg c3RhcnRzIHdpdGggYSBzd2l0Y2ggdG8gU1BEWCBsaWNlbnNlIGhlYWRlcnMgaW4gcGF0Y2ggMS84 LAo+ID4+IHByb21wdGVkIGJ5IGEgY2hlY2twYXRjaC5wbCB3YXJuaW5nIGZvciBhIGxhdGVyIHBh dGNoIHRoYXQgY29tcGxhaW5lZAo+ID4+IGFib3V0IG1pc3NpbmcgU1BEWCBsaWNlbnNlIGhlYWRl cnMuIEl0IHRoZW4gY29udGludWVzIHdpdGggY2xlYW51cCBhbmQKPiA+PiByZWZhY3RvcmluZy4g UGF0Y2hlcyAyLzggYW5kIDMvOCBwcmVwYXJlIGZvciBESVNDT00gYW5kIFVJRiBzdXBwb3J0IGJ5 Cj4gPj4gZXh0ZW5kaW5nIGdlbmVyaWMgY29kZSB0byBtYWtlIGl0IHVzYWJsZSBmb3IgdGhlIFVJ Ri4gUGF0Y2ggNC84IGRvY3VtZW50cwo+ID4+IGEgc3RydWN0dXJlIHRoYXQgd2lsbCByZWNlaXZl IG5ldyBmaWVsZHMuCj4gPj4gCj4gPj4gUGF0Y2ggNS84IHRoZW4gZXh0ZW5kcyB0aGUgQVBJIGV4 cG9zZWQgYnkgdGhlIFZTUCBkcml2ZXIgdG8gdGhlIERVIGRyaXZlcgo+ID4+IHRvIHN1cHBvcnQg Q1JDIGNvbXB1dGF0aW9uIGNvbmZpZ3VyYXRpb24gYW5kIHJlcG9ydGluZy4gVGhlIHBhdGNoCj4g Pj4gdW5mb3J0dW5hdGVseSBuZWVkcyB0byB0b3VjaCBib3RoIHRoZSBWU1AgYW5kIERVIGRyaXZl cnMsIHNvIHRoZSB3aG9sZQo+ID4+IHNlcmllcyB3aWxsIG5lZWQgdG8gYmUgbWVyZ2VkIHRocm91 Z2ggYSBzaW5nbGUgdHJlZS4KPiA+PiAKPiA+PiBQYXRjaCA1LzggYWRkcyBzdXBwb3J0IGZvciB0 aGUgRElTQ09NIGFuZCBVSUYgaW4gdGhlIFZTUCBkcml2ZXIsIHBhdGNoCj4gPj4gNy84IGludGVn cmF0ZXMgaXQgaW4gdGhlIERSTSBwaXBlbGluZSwgYW5kIHBhdGNoIDgvOCBmaW5hbGx5IGltcGxl bWVudHMKPiA+PiB0aGUgQ1JDIEFQSSBpbiB0aGUgRFUgZHJpdmVyIHRvIGV4cG9zZSBDUkMgY29t cHV0YXRpb24gdG8gdXNlcnNwYWNlLgo+ID4+IAo+ID4+IFRoZSBoYXJkd2FyZSBzdXBwb3J0cyBj b21wdXRpbmcgdGhlIENSQyBhdCBhbnkgYXJiaXRyYXJ5IHBvaW50IGluIHRoZQo+ID4+IHBpcGVs aW5lIG9uIGEgY29uZmlndXJhYmxlIHdpbmRvdyBvZiB0aGUgZnJhbWUuIFRoaXMgcGF0Y2ggc2Vy aWVzCj4gPj4gc3VwcG9ydHMgQ1JDIGNvbXB1dGF0aW9uIG9uIGlucHV0IHBsYW5lcyBvciBwaXBl bGluZSBvdXRwdXQsIGJ1dCBvbiB0aGUKPiA+PiBmdWxsIGZyYW1lIG9ubHkuIFN1cHBvcnQgZm9y IENSQyB3aW5kb3cgY29uZmlndXJhdGlvbiBjYW4gYmUgYWRkZWQgbGF0ZXIKPiA+PiBpZiBuZWVk ZWQgYnV0IHdpbGwgcmVxdWlyZSBleHRlbmRpbmcgdGhlIHVzZXJzcGFjZSBBUEksIGFzIHRoZSBE Uk0vS01TCj4gPj4gQ1JDIEFQSSBkb2Vzbid0IHN1cHBvcnQgdGhpcyBmZWF0dXJlLgo+ID4+IAo+ ID4+IENvbXBhcmVkIHRvIHYxLCB0aGUgQ1JDIHNvdXJjZSBuYW1lcyBmb3IgcGxhbmUgaW5wdXRz IGFyZSBub3cgY29uc3RydWN0ZWQKPiA+PiBmcm9tIHBsYW5lIElEcyBpbnN0ZWFkIG9mIHBsYW5l IGluZGljZXMuIFRoaXMgYWxsb3dzIHVzZXJzcGFjZSB0byBtYXRjaAo+ID4+IENSQyBzb3VyY2Vz IHdpdGggcGxhbmVzLgo+ID4+IAo+ID4+IENvbXBhcmVkIHRvIHYyLCB2YXJpb3VzIHNtYWxsIGlz c3VlcyByZXBvcnRlZCBieSByZXZpZXdlcnMgaGF2ZSBiZWVuCj4gPj4gZml4ZWQuIEkgYmVsaWV2 ZSB0aGUgc2VyaWVzIHRvIG5vdyBiZSByZWFkeSBmb3IgdXBzdHJlYW0gbWVyZ2UuCj4gPj4gCj4g Pj4gTm90ZSB0aGF0IGV4cG9zaW5nIHRoZSBESVNDT00gYW5kIFVJRiB0aG91Z2ggdGhlIFY0TDIg QVBJIGlzbid0IHN1cHBvcnRlZAo+ID4+IGFzIHRoZSBtb2R1bGUgaXMgb25seSBmb3VuZCBpbiBW U1AtRCBhbmQgVlNQLURMIGluc3RhbmNlcyB0aGF0IGFyZSBub3QKPiA+PiBleHBvc2VkIHRocm91 Z2ggVjRMMi4gSXQgaXMgcG9zc2libGUgdG8gZXhwb3NlIHRob3NlIGluc3RhbmNlcyB0aHJvdWdo Cj4gPj4gVjRMMiB3aXRoIGEgc21hbGwgbW9kaWZpY2F0aW9uIHRvIHRoZSBkcml2ZXIgZm9yIHRl c3RpbmcgcHVycG9zZS4gSWYgdGhlCj4gPj4gbmVlZCBhcmlzZXMgdG8gdGVzdCBESVNDT00gYW5k IFVJRiB3aXRoIHN1Y2ggYW4gb3V0LW9mLXRyZWUgcGF0Y2gsCj4gPj4gc3VwcG9ydCBmb3IgQ1JD IHJlcG9ydGluZyB0aHJvdWdoIGEgVjRMMiBjb250cm9sIGNhbiBiZSBhZGRlZCBsYXRlcgo+ID4+ IHdpdGhvdXQgYWZmZWN0aW5nIGhvdyBDUkMgaXMgZXhwb3NlZCB0aHJvdWdoIHRoZSBEUk0vS01T IEFQSS4KPiA+PiAKPiA+PiBUaGUgcGF0Y2hlcyBhcmUgYmFzZWQgb24gdG9wIG9mIHRoZSAiW1BB VENIIHYyIDAwLzE1XSBSLUNhciBWU1AxOgo+ID4+IER5bmFtaWNhbGx5IGFzc2lnbiBibGVuZCB1 bml0cyB0byBkaXNwbGF5IHBpcGVsaW5lcyIgcGF0Y2ggc2VyaWVzLCBpdHNlbGYKPiA+PiBiYXNl ZCBvbiB0b3Agb2YgdGhlIExpbnV4IG1lZGlhIG1hc3RlciBicmFuY2ggYW5kIHNjaGVkdWxlZCBm b3IgbWVyZ2UgaW4KPiA+PiB2NC4xOC4gVGhlIG5ldyBiYXNlIGNhdXNlZCBoZWF2eSBjb25mbGlj dHMsIHJlcXVpcmluZyB0aGlzIHNlcmllcyB0byBiZQo+ID4+IG1lcmdlZCB0aHJvdWdoIHRoZSBW NEwyIHRyZWUuCj4gPj4gCj4gPj4gRGF2ZSwgSSBoYXZlIHZlcmlmaWVkIHRoYXQgdGhpcyBzZXJp ZXMgbWVyZ2VzIGNsZWFubHkgd2l0aCB5b3VyIGRybS1uZXh0Cj4gPj4gYW5kIGRybS1maXhlcyBi cmFuY2hlcywgd2l0aCB0aGUgZHJtLW1pc2MtbmV4dCBhbmQgZHJtLW1pc2MtZml4ZXMKPiA+PiBi cmFuY2hlcywgYW5kIHdpdGggdGhlIFItQ2FyIERVIHBhdGNoZXMgSSB3b3VsZCBsaWtlIHRvIGdl dCBtZXJnZWQgaW4KPiA+PiB2NC4xOCB0aHJvdWdoIHlvdXIgdHJlZS4gQ291bGQgSSBnZXQgeW91 ciBhY2sgdG8gbWVyZ2UgdGhpcyB0aHJvdWdoIHRoZQo+ID4+IFY0TDIgdHJlZSA/Cj4gPj4gCj4g Pj4gRm9yIGNvbnZlbmllbmNlIHRoZSBwYXRjaGVzIGFyZSBhdmFpbGFibGUgYXQKPiA+PiAKPiA+ PiAgICAgICAgIGdpdDovL2xpbnV4dHYub3JnL3BpbmNoYXJ0bC9tZWRpYS5naXQgdnNwMS1kaXNj b20tdjMtMjAxODA0MjgKPiA+PiAKPiA+PiBUaGUgY29kZSBoYXMgYmVlbiB0ZXN0ZWQgdGhyb3Vn aCB0aGUga21zLXRlc3QtY3JjLnB5IHNjcmlwdCBwYXJ0IG9mIHRoZQo+ID4+IERVIHRlc3Qgc3Vp dGUgYXZhaWxhYmxlIGF0Cj4gPj4gCj4gPj4gICAgICAgICBnaXQ6Ly9naXQuaWRlYXNvbmJvYXJk LmNvbS9yZW5lc2FzL2ttcy10ZXN0cy5naXQgZGlzY29tCj4gPj4gCj4gPj4gTGF1cmVudCBQaW5j aGFydCAoOCk6Cj4gPj4gICB2NGw6IHZzcDE6IFVzZSBTUERYIGxpY2Vuc2UgaGVhZGVycwo+ID4+ ICAgdjRsOiB2c3AxOiBTaGFyZSB0aGUgQ0xVLCBMSUYgYW5kIExVVCBzZXRfZm10IHBhZCBvcGVy YXRpb24gY29kZQo+ID4+ICAgdjRsOiB2c3AxOiBSZXNldCB0aGUgY3JvcCBhbmQgY29tcG9zZSBy ZWN0YW5nbGVzIGluIHRoZSBzZXRfZm10IGhlbHBlcgo+ID4+ICAgdjRsOiB2c3AxOiBEb2N1bWVu dCB0aGUgdnNwMV9kdV9hdG9taWNfY29uZmlnIHN0cnVjdHVyZQo+ID4+ICAgdjRsOiB2c3AxOiBF eHRlbmQgdGhlIERVIEFQSSB0byBzdXBwb3J0IENSQyBjb21wdXRhdGlvbgo+ID4+ICAgdjRsOiB2 c3AxOiBBZGQgc3VwcG9ydCBmb3IgdGhlIERJU0NPTSBlbnRpdHkKPiA+PiAgIHY0bDogdnNwMTog SW50ZWdyYXRlIERJU0NPTSBpbiBkaXNwbGF5IHBpcGVsaW5lCj4gPj4gICBkcm06IHJjYXItZHU6 IEFkZCBzdXBwb3J0IGZvciBDUkMgY29tcHV0YXRpb24KPiA+PiAgCj4gPj4gIGRyaXZlcnMvZ3B1 L2RybS9yY2FyLWR1L3JjYXJfZHVfY3J0Yy5jICAgIHwgMTU2ICsrKysrKysrKysrKysrKystCj4g Pj4gIGRyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfY3J0Yy5oICAgIHwgIDE1ICsrCj4g Pj4gIGRyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfdnNwLmMgICAgIHwgIDEyICstCj4g Pj4gIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vdnNwMS9NYWtlZmlsZSAgICAgIHwgICAyICstCj4g Pj4gIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vdnNwMS92c3AxLmggICAgICAgIHwgIDEwICstCj4g Pj4gIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vdnNwMS92c3AxX2JyeC5jICAgIHwgICA2ICstCj4g Pj4gIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vdnNwMS92c3AxX2JyeC5oICAgIHwgICA2ICstCj4g Pj4gIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vdnNwMS92c3AxX2NsdS5jICAgIHwgIDcxICsrLS0t LS0tCj4gPj4gIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vdnNwMS92c3AxX2NsdS5oICAgIHwgICA2 ICstCj4gPj4gIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vdnNwMS92c3AxX2RsLmMgICAgIHwgICA4 ICstCj4gPj4gIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vdnNwMS92c3AxX2RsLmggICAgIHwgICA2 ICstCj4gPj4gIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vdnNwMS92c3AxX2RybS5jICAgIHwgMTI3 ICsrKysrKysrKysrKy0tCj4gPj4gIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vdnNwMS92c3AxX2Ry bS5oICAgIHwgIDE1ICstCj4gPj4gIGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vdnNwMS92c3AxX2Ry di5jICAgIHwgIDI2ICsrLQo+ID4+ICBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNwMV9l bnRpdHkuYyB8IDEwMyArKysrKysrKysrKy0KPiA+PiAgZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92 c3AxL3ZzcDFfZW50aXR5LmggfCAgMTMgKy0KPiA+PiAgZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92 c3AxL3ZzcDFfaGdvLmMgICAgfCAgIDYgKy0KPiA+PiAgZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92 c3AxL3ZzcDFfaGdvLmggICAgfCAgIDYgKy0KPiA+PiAgZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92 c3AxL3ZzcDFfaGd0LmMgICAgfCAgIDYgKy0KPiA+PiAgZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92 c3AxL3ZzcDFfaGd0LmggICAgfCAgIDYgKy0KPiA+PiAgZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92 c3AxL3ZzcDFfaGlzdG8uYyAgfCAgNjUgKy0tLS0tLQo+ID4+ICBkcml2ZXJzL21lZGlhL3BsYXRm b3JtL3ZzcDEvdnNwMV9oaXN0by5oICB8ICAgNiArLQo+ID4+ICBkcml2ZXJzL21lZGlhL3BsYXRm b3JtL3ZzcDEvdnNwMV9oc2l0LmMgICB8ICAgNiArLQo+ID4+ICBkcml2ZXJzL21lZGlhL3BsYXRm b3JtL3ZzcDEvdnNwMV9oc2l0LmggICB8ICAgNiArLQo+ID4+ICBkcml2ZXJzL21lZGlhL3BsYXRm b3JtL3ZzcDEvdnNwMV9saWYuYyAgICB8ICA3MSArKy0tLS0tLQo+ID4+ICBkcml2ZXJzL21lZGlh L3BsYXRmb3JtL3ZzcDEvdnNwMV9saWYuaCAgICB8ICAgNiArLQo+ID4+ICBkcml2ZXJzL21lZGlh L3BsYXRmb3JtL3ZzcDEvdnNwMV9sdXQuYyAgICB8ICA3MSArKy0tLS0tLQo+ID4+ICBkcml2ZXJz L21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNwMV9sdXQuaCAgICB8ICAgNiArLQo+ID4+ICBkcml2ZXJz L21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNwMV9waXBlLmMgICB8ICAgNiArLQo+ID4+ICBkcml2ZXJz L21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNwMV9waXBlLmggICB8ICAgNiArLQo+ID4+ICBkcml2ZXJz L21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNwMV9yZWdzLmggICB8ICA0NiArKysrLQo+ID4+ICBkcml2 ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNwMV9ycGYuYyAgICB8ICAgNiArLQo+ID4+ICBkcml2 ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNwMV9yd3BmLmMgICB8ICAgNiArLQo+ID4+ICBkcml2 ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNwMV9yd3BmLmggICB8ICAgNiArLQo+ID4+ICBkcml2 ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNwMV9zcnUuYyAgICB8ICAgNiArLQo+ID4+ICBkcml2 ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNwMV9zcnUuaCAgICB8ICAgNiArLQo+ID4+ICBkcml2 ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNwMV91ZHMuYyAgICB8ICAgNiArLQo+ID4+ICBkcml2 ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNwMV91ZHMuaCAgICB8ICAgNiArLQo+ID4+ICBkcml2 ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNwMV91aWYuYyAgICB8IDI3MSArKysrKysrKysrKysr KysrKysrKysrKysKPiA+PiAgZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92c3AxL3ZzcDFfdWlmLmgg ICAgfCAgMzIgKysrKwo+ID4+ICBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNwMV92aWRl by5jICB8ICAgNiArLQo+ID4+ICBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNwMV92aWRl by5oICB8ICAgNiArLQo+ID4+ICBkcml2ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNwMV93cGYu YyAgICB8ICAgNiArLQo+ID4+ICBpbmNsdWRlL21lZGlhL3ZzcDEuaCAgICAgICAgICAgICAgICAg ICAgICB8ICA0NSArKysrLQo+ID4+ICA0NCBmaWxlcyBjaGFuZ2VkLCA4OTIgaW5zZXJ0aW9ucygr KSwgNDE3IGRlbGV0aW9ucygtKQo+ID4+ICBjcmVhdGUgbW9kZSAxMDA2NDQgZHJpdmVycy9tZWRp YS9wbGF0Zm9ybS92c3AxL3ZzcDFfdWlmLmMKPiA+PiAgY3JlYXRlIG1vZGUgMTAwNjQ0IGRyaXZl cnMvbWVkaWEvcGxhdGZvcm0vdnNwMS92c3AxX3VpZi5oCgotLSAKUmVnYXJkcywKCkxhdXJlbnQg UGluY2hhcnQKCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from perceval.ideasonboard.com ([213.167.242.64]:49838 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750967AbeEEOGg (ORCPT ); Sat, 5 May 2018 10:06:36 -0400 From: Laurent Pinchart To: Daniel Vetter Cc: Dave Airlie , Kieran Bingham , dri-devel , "open list:DMA BUFFER SHARING FRAMEWORK" , Mauro Carvalho Chehab Subject: Re: [PATCH v3 0/8] R-Car DU: Support CRC calculation Date: Sat, 05 May 2018 17:06:50 +0300 Message-ID: <5038283.TSNOrsSzts@avalon> In-Reply-To: References: <20180428205027.18025-1-laurent.pinchart+renesas@ideasonboard.com> <4411331.L07MOrSnxD@avalon> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Daniel, (CC'ing Mauro) On Thursday, 3 May 2018 16:45:36 EEST Daniel Vetter wrote: > On Thu, May 3, 2018 at 2:06 PM, Laurent Pinchart wrote: > > Hi Dave, > > > > Ping ? > > Not aware of any crc core work going on in drm, so has my ack. Thank you. > Worst case we do a topic branch or something like that (since I guess you'll > do a pull request anyway on the v4l side). That would unfortunately not be possible, as Mauro cherry-picks patches instead of merging pull requests. In rare cases I can ask for a pull-request to be merged as-is, but it's too late in this case as the previous pull request that this series is based on has been cherry-picked, not merged. > Acked-by: me. > > > On Saturday, 28 April 2018 23:50:19 EEST Laurent Pinchart wrote: > >> Hello, > >> > >> (Dave, there's a request for you below) > >> > >> This patch series adds support for CRC calculation to the rcar-du-drm > >> driver. > >> > >> CRC calculation is supported starting at the Renesas R-Car Gen3 SoCs, as > >> earlier versions don't have the necessary hardware. On Gen3 SoCs, the CRC > >> is computed by the DISCOM module part of the VSP-D and VSP-DL. > >> > >> The DISCOM is interfaced to the VSP through the UIF glue and appears as a > >> VSP entity with a sink pad and a source pad. > >> > >> The series starts with a switch to SPDX license headers in patch 1/8, > >> prompted by a checkpatch.pl warning for a later patch that complained > >> about missing SPDX license headers. It then continues with cleanup and > >> refactoring. Patches 2/8 and 3/8 prepare for DISCOM and UIF support by > >> extending generic code to make it usable for the UIF. Patch 4/8 documents > >> a structure that will receive new fields. > >> > >> Patch 5/8 then extends the API exposed by the VSP driver to the DU driver > >> to support CRC computation configuration and reporting. The patch > >> unfortunately needs to touch both the VSP and DU drivers, so the whole > >> series will need to be merged through a single tree. > >> > >> Patch 5/8 adds support for the DISCOM and UIF in the VSP driver, patch > >> 7/8 integrates it in the DRM pipeline, and patch 8/8 finally implements > >> the CRC API in the DU driver to expose CRC computation to userspace. > >> > >> The hardware supports computing the CRC at any arbitrary point in the > >> pipeline on a configurable window of the frame. This patch series > >> supports CRC computation on input planes or pipeline output, but on the > >> full frame only. Support for CRC window configuration can be added later > >> if needed but will require extending the userspace API, as the DRM/KMS > >> CRC API doesn't support this feature. > >> > >> Compared to v1, the CRC source names for plane inputs are now constructed > >> from plane IDs instead of plane indices. This allows userspace to match > >> CRC sources with planes. > >> > >> Compared to v2, various small issues reported by reviewers have been > >> fixed. I believe the series to now be ready for upstream merge. > >> > >> Note that exposing the DISCOM and UIF though the V4L2 API isn't supported > >> as the module is only found in VSP-D and VSP-DL instances that are not > >> exposed through V4L2. It is possible to expose those instances through > >> V4L2 with a small modification to the driver for testing purpose. If the > >> need arises to test DISCOM and UIF with such an out-of-tree patch, > >> support for CRC reporting through a V4L2 control can be added later > >> without affecting how CRC is exposed through the DRM/KMS API. > >> > >> The patches are based on top of the "[PATCH v2 00/15] R-Car VSP1: > >> Dynamically assign blend units to display pipelines" patch series, itself > >> based on top of the Linux media master branch and scheduled for merge in > >> v4.18. The new base caused heavy conflicts, requiring this series to be > >> merged through the V4L2 tree. > >> > >> Dave, I have verified that this series merges cleanly with your drm-next > >> and drm-fixes branches, with the drm-misc-next and drm-misc-fixes > >> branches, and with the R-Car DU patches I would like to get merged in > >> v4.18 through your tree. Could I get your ack to merge this through the > >> V4L2 tree ? > >> > >> For convenience the patches are available at > >> > >> git://linuxtv.org/pinchartl/media.git vsp1-discom-v3-20180428 > >> > >> The code has been tested through the kms-test-crc.py script part of the > >> DU test suite available at > >> > >> git://git.ideasonboard.com/renesas/kms-tests.git discom > >> > >> Laurent Pinchart (8): > >> v4l: vsp1: Use SPDX license headers > >> v4l: vsp1: Share the CLU, LIF and LUT set_fmt pad operation code > >> v4l: vsp1: Reset the crop and compose rectangles in the set_fmt helper > >> v4l: vsp1: Document the vsp1_du_atomic_config structure > >> v4l: vsp1: Extend the DU API to support CRC computation > >> v4l: vsp1: Add support for the DISCOM entity > >> v4l: vsp1: Integrate DISCOM in display pipeline > >> drm: rcar-du: Add support for CRC computation > >> > >> drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 156 ++++++++++++++++- > >> drivers/gpu/drm/rcar-du/rcar_du_crtc.h | 15 ++ > >> drivers/gpu/drm/rcar-du/rcar_du_vsp.c | 12 +- > >> drivers/media/platform/vsp1/Makefile | 2 +- > >> drivers/media/platform/vsp1/vsp1.h | 10 +- > >> drivers/media/platform/vsp1/vsp1_brx.c | 6 +- > >> drivers/media/platform/vsp1/vsp1_brx.h | 6 +- > >> drivers/media/platform/vsp1/vsp1_clu.c | 71 ++------ > >> drivers/media/platform/vsp1/vsp1_clu.h | 6 +- > >> drivers/media/platform/vsp1/vsp1_dl.c | 8 +- > >> drivers/media/platform/vsp1/vsp1_dl.h | 6 +- > >> drivers/media/platform/vsp1/vsp1_drm.c | 127 ++++++++++++-- > >> drivers/media/platform/vsp1/vsp1_drm.h | 15 +- > >> drivers/media/platform/vsp1/vsp1_drv.c | 26 ++- > >> drivers/media/platform/vsp1/vsp1_entity.c | 103 +++++++++++- > >> drivers/media/platform/vsp1/vsp1_entity.h | 13 +- > >> drivers/media/platform/vsp1/vsp1_hgo.c | 6 +- > >> drivers/media/platform/vsp1/vsp1_hgo.h | 6 +- > >> drivers/media/platform/vsp1/vsp1_hgt.c | 6 +- > >> drivers/media/platform/vsp1/vsp1_hgt.h | 6 +- > >> drivers/media/platform/vsp1/vsp1_histo.c | 65 +------ > >> drivers/media/platform/vsp1/vsp1_histo.h | 6 +- > >> drivers/media/platform/vsp1/vsp1_hsit.c | 6 +- > >> drivers/media/platform/vsp1/vsp1_hsit.h | 6 +- > >> drivers/media/platform/vsp1/vsp1_lif.c | 71 ++------ > >> drivers/media/platform/vsp1/vsp1_lif.h | 6 +- > >> drivers/media/platform/vsp1/vsp1_lut.c | 71 ++------ > >> drivers/media/platform/vsp1/vsp1_lut.h | 6 +- > >> drivers/media/platform/vsp1/vsp1_pipe.c | 6 +- > >> drivers/media/platform/vsp1/vsp1_pipe.h | 6 +- > >> drivers/media/platform/vsp1/vsp1_regs.h | 46 ++++- > >> drivers/media/platform/vsp1/vsp1_rpf.c | 6 +- > >> drivers/media/platform/vsp1/vsp1_rwpf.c | 6 +- > >> drivers/media/platform/vsp1/vsp1_rwpf.h | 6 +- > >> drivers/media/platform/vsp1/vsp1_sru.c | 6 +- > >> drivers/media/platform/vsp1/vsp1_sru.h | 6 +- > >> drivers/media/platform/vsp1/vsp1_uds.c | 6 +- > >> drivers/media/platform/vsp1/vsp1_uds.h | 6 +- > >> drivers/media/platform/vsp1/vsp1_uif.c | 271 ++++++++++++++++++++++++ > >> drivers/media/platform/vsp1/vsp1_uif.h | 32 ++++ > >> drivers/media/platform/vsp1/vsp1_video.c | 6 +- > >> drivers/media/platform/vsp1/vsp1_video.h | 6 +- > >> drivers/media/platform/vsp1/vsp1_wpf.c | 6 +- > >> include/media/vsp1.h | 45 ++++- > >> 44 files changed, 892 insertions(+), 417 deletions(-) > >> create mode 100644 drivers/media/platform/vsp1/vsp1_uif.c > >> create mode 100644 drivers/media/platform/vsp1/vsp1_uif.h -- Regards, Laurent Pinchart