From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50144) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T5Xxm-0003Dy-Fn for qemu-devel@nongnu.org; Sun, 26 Aug 2012 04:12:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1T5Xxl-000690-DD for qemu-devel@nongnu.org; Sun, 26 Aug 2012 04:12:54 -0400 Received: from mout.web.de ([212.227.15.4]:50155) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1T5Xxl-00068g-3e for qemu-devel@nongnu.org; Sun, 26 Aug 2012 04:12:53 -0400 Message-ID: <5039DA7F.2090607@web.de> Date: Sun, 26 Aug 2012 10:12:47 +0200 From: Jan Kiszka MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [PATCH for 1.2] memory: Fix copy&paste mistake in memory_region_iorange_write List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel , Anthony Liguori Cc: Avi Kivity From: Jan Kiszka The last argument of find_portio is "write", so this must be true here. Signed-off-by: Jan Kiszka --- We were likely lucky so far and didn't hit this - it would have caused an assertion. However, there are also rarely used devices... memory.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/memory.c b/memory.c index 643871b..d528d1f 100644 --- a/memory.c +++ b/memory.c @@ -426,7 +426,7 @@ static void memory_region_iorange_write(IORange *iorange, if (mrp) { mrp->write(mr->opaque, offset, data); } else if (width == 2) { - mrp = find_portio(mr, offset - mrio->offset, 1, false); + mrp = find_portio(mr, offset - mrio->offset, 1, true); assert(mrp); mrp->write(mr->opaque, offset, data & 0xff); mrp->write(mr->opaque, offset + 1, data >> 8); -- 1.7.3.4