From: "Stefan Fröberg" <stefan.froberg@petroprogram.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] remove rest of the BR2_SOURCEFORGE_MIRROR references
Date: Sun, 26 Aug 2012 13:51:39 +0300 [thread overview]
Message-ID: <5039FFBB.6040205@petroprogram.com> (raw)
In-Reply-To: <20120826093901.75f17f9c@skate>
26.8.2012 10:39, Thomas Petazzoni kirjoitti:
> Hello,
>
> Thanks! Some comments below.
>
> Le Sun, 26 Aug 2012 02:52:48 +0300,
> Stefan Fr?berg <stefan.froberg@petroprogram.com> a ?crit :
>
>> diff --git a/package/genromfs/genromfs.mk b/package/genromfs/genromfs.mk
>> index c1cd608..3f5d44e 100644
>> --- a/package/genromfs/genromfs.mk
>> +++ b/package/genromfs/genromfs.mk
>> @@ -6,7 +6,7 @@
>>
>> GENROMFS_VERSION=0.5.2
>> GENROMFS_SOURCE=genromfs-$(GENROMFS_VERSION).tar.gz
>> -GENROMFS_SITE=http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/sourceforge/romfs
>> +GENROMFS_SITE=http://downloads.sourceforge.net/project/romfs/genromfs/$(GENROMFS_VERSION)
>>
>> define GENROMFS_BUILD_CMDS
>> $(TARGET_MAKE_ENV) $(MAKE) -C $(@D) \
>> @@ -28,4 +28,4 @@ define HOST_GENROMFS_INSTALL_CMDS
>> endef
>>
>> $(eval $(generic-package))
>> -$(eval $(host-generic-package))
>> \ No newline at end of file
>> +$(eval $(host-generic-package))
> You're adding a newline here (which was missing), but ok.
Oops!
>> diff --git a/package/poco/poco.mk b/package/poco/poco.mk
>> index f74c2b1..e59e812 100644
>> --- a/package/poco/poco.mk
>> +++ b/package/poco/poco.mk
>> @@ -3,9 +3,9 @@
>> # poco
>> #
>> #############################################################
>> -POCO_VERSION = 1.4.3p1
>> -POCO_SOURCE = poco-$(POCO_VERSION)-all.tar.gz
>> -POCO_SITE = http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/sourceforge/poco
>> +POCO_VERSION = 1.4.3
>> +POCO_SOURCE = poco-$(POCO_VERSION)p1-all.tar.gz
>> +POCO_SITE = http://downloads.sourceforge.net/project/poco/sources/poco-$(POCO_VERSION)
> No, I don't agree with this. The "p1" should be part of the version. So
> you should do something like:
>
> POCO_VERSION_MAJOR = 1.4.3
> POCO_VERSION = $(POCO_VERSION_MAJOR)p1
> POCO_SOURCE = poco-$(POCO_VERSION)-all.tar.gz
> POCO_SITE = http://downloads.sourceforge.net/project/poco/sources/poco-$(POCO_VERSION_MAJOR)
Ah, ok
>> diff --git a/package/synergy/synergy.mk b/package/synergy/synergy.mk
>> index b1afff7..0f492e7 100644
>> --- a/package/synergy/synergy.mk
>> +++ b/package/synergy/synergy.mk
>> @@ -1,4 +1,4 @@
>> -#############################################################
>> + #############################################################
> Why ?
Another oops
3 mistakes out of 86 within one saturday evening hour.
Not too bad ;)
Stefan
>> #
>> # synergy
>> #
>> @@ -6,7 +6,7 @@
>>
>> SYNERGY_VERSION = 1.3.1
>> SYNERGY_SOURCE = synergy-$(SYNERGY_VERSION).tar.gz
>> -SYNERGY_SITE = http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/sourceforge/synergy2/
>> +SYNERGY_SITE = http://downloads.sourceforge.net/project/synergy2/Sources/$(SYNERGY_VERSION)
> Thanks!
>
> Thomas
next prev parent reply other threads:[~2012-08-26 10:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-25 23:52 [Buildroot] [PATCH] remove rest of the BR2_SOURCEFORGE_MIRROR references Stefan Fröberg
2012-08-26 7:39 ` Thomas Petazzoni
2012-08-26 10:51 ` Stefan Fröberg [this message]
2012-08-27 21:27 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5039FFBB.6040205@petroprogram.com \
--to=stefan.froberg@petroprogram.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.