All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Jonathan Cameron <jic23@cam.ac.uk>, linux-iio@vger.kernel.org
Subject: Re: [PATCH 2/3] iio: Add missing include guards to headers
Date: Mon, 27 Aug 2012 18:47:13 +0100	[thread overview]
Message-ID: <503BB2A1.904@kernel.org> (raw)
In-Reply-To: <1345219066-5338-2-git-send-email-lars@metafoo.de>

On 08/17/2012 04:57 PM, Lars-Peter Clausen wrote:
> Add include guards to the IIO headers where they are missing. This avoids
> compile errors due to redefined types if a file is included more than once.
> 
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
merge to togreg
> 
> ---
> strictly speaking kfifo_buf.h does not need one, since it only declares
> functions, but I'd consider it to be good style to have them anyway.
> ---
>  include/linux/iio/kfifo_buf.h        |    3 +++
>  include/linux/iio/machine.h          |    5 +++++
>  include/linux/iio/trigger_consumer.h |    5 +++++
>  3 files changed, 13 insertions(+)
> 
> diff --git a/include/linux/iio/kfifo_buf.h b/include/linux/iio/kfifo_buf.h
> index 014d5a1..25eeac7 100644
> --- a/include/linux/iio/kfifo_buf.h
> +++ b/include/linux/iio/kfifo_buf.h
> @@ -1,3 +1,5 @@
> +#ifndef __LINUX_IIO_KFIFO_BUF_H__
> +#define __LINUX_IIO_KFIFO_BUF_H__
>  
>  #include <linux/kfifo.h>
>  #include <linux/iio/iio.h>
> @@ -6,3 +8,4 @@
>  struct iio_buffer *iio_kfifo_allocate(struct iio_dev *indio_dev);
>  void iio_kfifo_free(struct iio_buffer *r);
>  
> +#endif
> diff --git a/include/linux/iio/machine.h b/include/linux/iio/machine.h
> index 400a453..809a3f0 100644
> --- a/include/linux/iio/machine.h
> +++ b/include/linux/iio/machine.h
> @@ -8,6 +8,9 @@
>   * the Free Software Foundation.
>   */
>  
> +#ifndef __LINUX_IIO_MACHINE_H__
> +#define __LINUX_IIO_MACHINE_H__
> +
>  /**
>   * struct iio_map - description of link between consumer and device channels
>   * @adc_channel_label:	Label used to identify the channel on the provider.
> @@ -22,3 +25,5 @@ struct iio_map {
>  	const char *consumer_dev_name;
>  	const char *consumer_channel;
>  };
> +
> +#endif
> diff --git a/include/linux/iio/trigger_consumer.h b/include/linux/iio/trigger_consumer.h
> index 60d64b3..762a3d3 100644
> --- a/include/linux/iio/trigger_consumer.h
> +++ b/include/linux/iio/trigger_consumer.h
> @@ -7,6 +7,9 @@
>   * the Free Software Foundation.
>   */
>  
> +#ifndef __LINUX_IIO_TRIGGER_CONSUMER_H__
> +#define __LINUX_IIO_TRIGGER_CONSUMER_H__
> +
>  /**
>   * struct iio_poll_func - poll function pair
>   *
> @@ -50,3 +53,5 @@ void iio_trigger_notify_done(struct iio_trigger *trig);
>   */
>  int iio_triggered_buffer_postenable(struct iio_dev *indio_dev);
>  int iio_triggered_buffer_predisable(struct iio_dev *indio_dev);
> +
> +#endif
> 

  reply	other threads:[~2012-08-27 17:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-17 15:57 [PATCH 1/3] iio:consumer.h: Fix include guard Lars-Peter Clausen
2012-08-17 15:57 ` [PATCH 2/3] iio: Add missing include guards to headers Lars-Peter Clausen
2012-08-27 17:47   ` Jonathan Cameron [this message]
2012-08-17 15:57 ` [PATCH 3/3] iio:trigger_consumer.h: Add missing includes and forward declarations Lars-Peter Clausen
2012-08-27 17:47   ` Jonathan Cameron
2012-08-27 17:47 ` [PATCH 1/3] iio:consumer.h: Fix include guard Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=503BB2A1.904@kernel.org \
    --to=jic23@kernel.org \
    --cc=jic23@cam.ac.uk \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.