From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Cameron Date: Mon, 27 Aug 2012 20:09:08 +0000 Subject: Re: [PATCH 1/13] drivers/staging/iio/adc/spear_adc.c: use clk_prepare_enable and clk_disable_unprepa Message-Id: <503BD3E4.4080300@kernel.org> List-Id: References: <1345996865-32082-1-git-send-email-Julia.Lawall@lip6.fr> <1345996865-32082-2-git-send-email-Julia.Lawall@lip6.fr> <503BD353.3070203@kernel.org> In-Reply-To: <503BD353.3070203@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: viresh kumar Cc: Julia Lawall , Stefan Roese , Shiraz HASHIM , Jonathan Cameron , kernel-janitors@vger.kernel.org, Greg Kroah-Hartman , linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, spear-devel On 08/27/2012 09:06 PM, Jonathan Cameron wrote: > On 08/27/2012 05:01 AM, viresh kumar wrote: >> On Sun, Aug 26, 2012 at 9:30 PM, Julia Lawall wrote: >>> From: Julia Lawall >>> >>> Clk_prepare_enable and clk_disable_unprepare combine clk_prepare and >>> clk_enable, and clk_disable and clk_unprepare. They make the code more >>> concise, and ensure that clk_unprepare is called when clk_enable fails. >>> >>> A simplified version of the semantic patch that introduces calls to these >>> functions is as follows: (http://coccinelle.lip6.fr/) >> >> Reviewed-by: Viresh Kumar > merged to fixes-togreg branch of kernel.org iio.git will push onwards in a few > days... sorry, wrong branch as clearly just a cleanup not a fix. Will be in togreg branch instead. >> >> @Stefan/Shiraz: Can you update spear-devel mailing list in MAINTAINERS file >> for this driver? >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-iio" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:57428 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754209Ab2H0UJO (ORCPT ); Mon, 27 Aug 2012 16:09:14 -0400 Message-ID: <503BD3E4.4080300@kernel.org> Date: Mon, 27 Aug 2012 21:09:08 +0100 From: Jonathan Cameron MIME-Version: 1.0 To: viresh kumar CC: Julia Lawall , Stefan Roese , Shiraz HASHIM , Jonathan Cameron , kernel-janitors@vger.kernel.org, Greg Kroah-Hartman , linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, spear-devel Subject: Re: [PATCH 1/13] drivers/staging/iio/adc/spear_adc.c: use clk_prepare_enable and clk_disable_unprepare References: <1345996865-32082-1-git-send-email-Julia.Lawall@lip6.fr> <1345996865-32082-2-git-send-email-Julia.Lawall@lip6.fr> <503BD353.3070203@kernel.org> In-Reply-To: <503BD353.3070203@kernel.org> Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 08/27/2012 09:06 PM, Jonathan Cameron wrote: > On 08/27/2012 05:01 AM, viresh kumar wrote: >> On Sun, Aug 26, 2012 at 9:30 PM, Julia Lawall wrote: >>> From: Julia Lawall >>> >>> Clk_prepare_enable and clk_disable_unprepare combine clk_prepare and >>> clk_enable, and clk_disable and clk_unprepare. They make the code more >>> concise, and ensure that clk_unprepare is called when clk_enable fails. >>> >>> A simplified version of the semantic patch that introduces calls to these >>> functions is as follows: (http://coccinelle.lip6.fr/) >> >> Reviewed-by: Viresh Kumar > merged to fixes-togreg branch of kernel.org iio.git will push onwards in a few > days... sorry, wrong branch as clearly just a cleanup not a fix. Will be in togreg branch instead. >> >> @Stefan/Shiraz: Can you update spear-devel mailing list in MAINTAINERS file >> for this driver? >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-iio" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >