From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adam Jackson Subject: Re: -next queue and EDID stuff Date: Mon, 27 Aug 2012 16:24:02 -0400 Message-ID: <503BD762.6070204@redhat.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by gabe.freedesktop.org (Postfix) with ESMTP id 4741C9E763 for ; Mon, 27 Aug 2012 13:24:05 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Dave Airlie Cc: dri-devel List-Id: dri-devel@lists.freedesktop.org On 8/23/12 7:50 PM, Dave Airlie wrote: > Hi guys (but mainly ajax) > > I have a bunch of EDID and quirk stuff outstanding, > > I've made a bundle on patchwork for it > https://patchwork.kernel.org/bundle/airlied/edid-review/ https://patchwork.kernel.org/patch/1364501/ - I'm nervous about this on non-EDDC monitors, things are touchy enough as it is. Would prefer if we did the normal 2-message thing for blocks 0 and 1, and only did 3 messages if segment != 0. https://patchwork.kernel.org/patch/1310091/ - nak, the commit message itself gives away that we're doing else something wrong here. If DISABLE_AUDIO is sufficient for one driver it should be sufficient for all. For the rest (though I have some complaints that aren't enough to justify saying no): Reviewed-by: Adam Jackson Paul's FORCE_REDUCED_BLANKING series makes me nervous about what those monitors will do over VGA, since from a conversation we had on IRC he hasn't been able to test that. I don't really see the point in the EDID_MFG_ID() bit of the quirks rework. Have we actually seen a monitor where that field was malformed in a way that would require it? - ajax