From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Young Subject: Re: [PATCH] use check_block_and_slaves in for_each_host_dev_and_slaves Date: Tue, 28 Aug 2012 10:08:14 +0800 Message-ID: <503C280E.6000505@redhat.com> References: <20120828020549.GA6961@dhcp-16-143.nay.redhat.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120828020549.GA6961-je1gSBvt1Td3da3rpXeqgR/sF2h8X+2i0E9HWUfgJXw@public.gmane.org> Sender: initramfs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" To: harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, chaowang-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On 08/28/2012 10:05 AM, Dave Young wrote: > > for_each_host_dev_and_slaves currently is used in some module check() > functions and it's not necessary iterate all slaves. So use > check_block_and_slaves instead of check_block_and_slaves_all is fine. Hi, harald Thanks for cleanup the redundant "echo" lines in my last patch series Could you apply this cleanup as well? > > Signed-off-by: Dave Young > --- > dracut-functions.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- dracut.orig/dracut-functions.sh > +++ dracut/dracut-functions.sh > @@ -468,7 +468,7 @@ for_each_host_dev_and_slaves() > local _dev > for _dev in ${host_devs[@]}; do > [[ -b "$_dev" ]] || continue > - check_block_and_slaves_all $_func $(get_maj_min $_dev) && return 0 > + check_block_and_slaves $_func $(get_maj_min $_dev) && return 0 > done > return 1 > } > -- > To unsubscribe from this list: send the line "unsubscribe initramfs" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Thanks Dave