All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: axboe@kernel.dk
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] sg_io: allow UNMAP and WRITE SAME without CAP_SYS_RAWIO
Date: Tue, 28 Aug 2012 13:04:26 +0200	[thread overview]
Message-ID: <503CA5BA.2040003@redhat.com> (raw)
In-Reply-To: <50195108.1090105@redhat.com>

Il 01/08/2012 17:53, Paolo Bonzini ha scritto:
> Il 20/07/2012 18:30, Paolo Bonzini ha scritto:
>> These commands cannot be issued right now without giving CAP_SYS_RAWIO to
>> the process who wishes to send them.  These commands can be useful also to
>> non-privileged programs who have access to the block devices.  For example
>> a virtual machine monitor needs them to forward trim/discard to host disks.
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>>  block/scsi_ioctl.c |    3 ++
>>  1 files changed, 3 insertions(+), 0 deletions(-)
>>
>> diff --git a/block/scsi_ioctl.c b/block/scsi_ioctl.c
>> index 260fa80..dd71f18 100644
>> --- a/block/scsi_ioctl.c
>> +++ b/block/scsi_ioctl.c
>> @@ -168,13 +168,16 @@ static void blk_set_cmd_filter_defaults(struct blk_cmd_filter *filter)
>>  	/* Basic writing commands */
>>  	__set_bit(WRITE_6, filter->write_ok);
>>  	__set_bit(WRITE_10, filter->write_ok);
>> +	__set_bit(WRITE_SAME, filter->write_ok);
>>  	__set_bit(WRITE_VERIFY, filter->write_ok);
>>  	__set_bit(WRITE_12, filter->write_ok);
>>  	__set_bit(WRITE_VERIFY_12, filter->write_ok);
>>  	__set_bit(WRITE_16, filter->write_ok);
>> +	__set_bit(WRITE_SAME_16, filter->write_ok);
>>  	__set_bit(WRITE_LONG, filter->write_ok);
>>  	__set_bit(WRITE_LONG_2, filter->write_ok);
>>  	__set_bit(ERASE, filter->write_ok);
>> +	__set_bit(UNMAP, filter->write_ok);
>>  	__set_bit(GPCMD_MODE_SELECT_10, filter->write_ok);
>>  	__set_bit(MODE_SELECT, filter->write_ok);
>>  	__set_bit(LOG_SELECT, filter->write_ok);
>>
> 
> Jens,
> 
> can this go in 3.6 as well?

Another ping...

Paolo


  reply	other threads:[~2012-08-28 11:04 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-20 16:30 [PATCH] sg_io: allow UNMAP and WRITE SAME without CAP_SYS_RAWIO Paolo Bonzini
2012-08-01 15:53 ` Paolo Bonzini
2012-08-28 11:04   ` Paolo Bonzini [this message]
2012-09-05 14:41     ` [Ping^3] " Paolo Bonzini
2012-09-05 20:18       ` Ric Wheeler
2012-09-06  6:31         ` Paolo Bonzini
2012-09-06 11:31           ` Ric Wheeler
2012-09-06 11:49             ` Paolo Bonzini
2012-09-06 12:08               ` Ric Wheeler
2012-09-06 12:36                 ` Paolo Bonzini
2012-09-06 14:20                   ` Lukáš Czerner
2012-09-11 16:59 ` Tejun Heo
2012-09-11 17:56   ` Paolo Bonzini
2012-09-11 18:29     ` Tejun Heo
2012-09-11 18:54       ` Paolo Bonzini
2012-09-11 19:13         ` Tejun Heo
2012-09-11 19:24           ` Paolo Bonzini
2012-09-11 20:01             ` Tejun Heo
2012-09-11 21:50               ` Paolo Bonzini
2012-09-11 22:02                 ` Tejun Heo
2012-09-11 22:10                   ` Paolo Bonzini
2012-09-11 22:13                     ` Tejun Heo
2012-09-12  8:05     ` James Bottomley
2012-09-12  8:18       ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=503CA5BA.2040003@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.