From: Rupesh Gujare <rgujare@ozmodevices.com>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: <ckelly@ozmodevices.com>, <gregkh@linuxfoundation.org>,
<yongjun_wei@trendmicro.com.cn>, <devel@driverdev.osuosl.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: ozwpan: remove pointless conditional before kfree_skb()
Date: Tue, 28 Aug 2012 21:57:10 +0100 [thread overview]
Message-ID: <503D30A6.3000800@ozmodevices.com> (raw)
In-Reply-To: <CAPgLHd_u2CE7PAhS4Y9MtbY=ZFphZfUrYYiqD_gx6-kf1O0C-w@mail.gmail.com>
On 28/08/2012 14:11, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Remove pointless conditional before kfree_skb().
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/staging/ozwpan/ozpd.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/ozwpan/ozpd.c b/drivers/staging/ozwpan/ozpd.c
> index 6c287ac..d515714 100644
> --- a/drivers/staging/ozwpan/ozpd.c
> +++ b/drivers/staging/ozwpan/ozpd.c
> @@ -752,8 +752,7 @@ int oz_isoc_stream_create(struct oz_pd *pd, u8 ep_num)
> */
> static void oz_isoc_stream_free(struct oz_isoc_stream *st)
> {
> - if (st->skb)
> - kfree_skb(st->skb);
> + kfree_skb(st->skb);
> kfree(st);
> }
> /*------------------------------------------------------------------------------
>
>
Acked-by: Rupesh Gujare <rgujare@ozmodevices.com>
prev parent reply other threads:[~2012-08-28 20:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-28 13:11 [PATCH] staging: ozwpan: remove pointless conditional before kfree_skb() Wei Yongjun
2012-08-28 20:57 ` Rupesh Gujare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=503D30A6.3000800@ozmodevices.com \
--to=rgujare@ozmodevices.com \
--cc=ckelly@ozmodevices.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=weiyj.lk@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.