From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joonyoung Shim Subject: Re: [PATCH] drm/exynos: Make g2d_pm_ops static Date: Wed, 29 Aug 2012 16:02:52 +0900 Message-ID: <503DBE9C.8000204@samsung.com> References: <1346143301-1631-1-git-send-email-sachin.kamat@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) by gabe.freedesktop.org (Postfix) with ESMTP id 408089E90A for ; Wed, 29 Aug 2012 00:02:52 -0700 (PDT) Received: from epcpsbgm1.samsung.com (epcpsbgm1 [203.254.230.26]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0M9I00IEV8W236O0@mailout2.samsung.com> for dri-devel@lists.freedesktop.org; Wed, 29 Aug 2012 16:02:50 +0900 (KST) Received: from [10.90.51.60] by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0M9I00B278WP9Y30@mmp1.samsung.com> for dri-devel@lists.freedesktop.org; Wed, 29 Aug 2012 16:02:49 +0900 (KST) In-reply-to: <1346143301-1631-1-git-send-email-sachin.kamat@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Sachin Kamat Cc: dri-devel@lists.freedesktop.org, patches@linaro.org List-Id: dri-devel@lists.freedesktop.org On 08/28/2012 05:41 PM, Sachin Kamat wrote: > Fixes the following warning: > drivers/gpu/drm/exynos/exynos_drm_g2d.c:897:1: warning: > symbol 'g2d_pm_ops' was not declared. Should it be static? > > Signed-off-by: Sachin Kamat > --- > drivers/gpu/drm/exynos/exynos_drm_g2d.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c > index 6adfa4e..1065e90 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c > @@ -894,7 +894,7 @@ static int g2d_resume(struct device *dev) > } > #endif > > -SIMPLE_DEV_PM_OPS(g2d_pm_ops, g2d_suspend, g2d_resume); > +static SIMPLE_DEV_PM_OPS(g2d_pm_ops, g2d_suspend, g2d_resume); Right, it should be static but i don't get any warning message without static. Thanks. > > struct platform_driver g2d_driver = { > .probe = g2d_probe,