From: Paolo Bonzini <pbonzini@redhat.com>
To: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanha@gmail.com,
qemu-devel@nongnu.org, blauwirbel@gmail.com, eblake@redhat.com,
afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH v3 1/5] [RFC] libqblock, API design
Date: Wed, 29 Aug 2012 13:12:35 +0200 [thread overview]
Message-ID: <503DF923.9030009@redhat.com> (raw)
In-Reply-To: <1346238199-24425-1-git-send-email-xiawenc@linux.vnet.ibm.com>
Il 29/08/2012 13:03, Wenchao Xia ha scritto:
> +struct QBlockOption_prot_file {
> + char *filename;
> +};
> +
> +union QBlockOption_prot {
> + struct QBlockOption_prot_file o_file;
> +};
> +
> +/**
> + * struct QBlockOptionLoc: contains information about how to find the image
> + *
> + * @prot_type: protocol type, now only support FILE.
> + * @prot_op: protocol related options.
> + */
> +struct QBlockOptionLoc {
> + enum QBlockProtocol prot_type;
> + union QBlockOption_prot prot_op;
> + uint8_t reserved[512];
The padding must be part of the union, not the struct.
Paolo
next prev parent reply other threads:[~2012-08-29 11:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-29 11:03 [Qemu-devel] [PATCH v3 1/5] [RFC] libqblock, API design Wenchao Xia
2012-08-29 11:12 ` Paolo Bonzini [this message]
2012-08-30 1:53 ` Wenchao Xia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=503DF923.9030009@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=xiawenc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.