From: John Crispin <blogic@openwrt.org>
To: dedekind1@gmail.com
Cc: Gabor Juhos <juhosg@openwrt.org>,
emong@vip.qq.com, David Woodhouse <dwmw2@infradead.org>,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd: m25p80: add support for the EON EN25Q64 chip
Date: Wed, 29 Aug 2012 13:13:26 +0200 [thread overview]
Message-ID: <503DF956.6030308@openwrt.org> (raw)
In-Reply-To: <1346238245.2848.468.camel@sauron.fi.intel.com>
On 29/08/12 13:04, Artem Bityutskiy wrote:
> On Sun, 2012-08-26 at 10:37 +0200, Gabor Juhos wrote:
>> Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
>> ---
>> drivers/mtd/devices/m25p80.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
>> index 5d0d68c..d812552 100644
>> --- a/drivers/mtd/devices/m25p80.c
>> +++ b/drivers/mtd/devices/m25p80.c
>> @@ -638,6 +638,7 @@ static const struct spi_device_id m25p_ids[] = {
>> { "en25p32", INFO(0x1c2016, 0, 64 * 1024, 64, 0) },
>> { "en25q32b", INFO(0x1c3016, 0, 64 * 1024, 64, 0) },
>> { "en25p64", INFO(0x1c2017, 0, 64 * 1024, 128, 0) },
>> + { "en25q64", INFO(0x1c3017, 0, 64 * 1024, 128, SECT_4K) },
> I've already pushed a similar patch from "John Crispin
> <blogic@openwrt.org>", but it did not have "SECT_4K". So I am not
> picking this one.
>
Hi Artem,
the patch is based on this ticket ->
https://dev.openwrt.org/ticket/12077
i verified it against the datasheet. the datasheet indicates that
SECT_4K should work, but as the patch was only runtime tested without
the SECT_4K i did not add it.
Gabor told me that the SECT_4K was runtime tested on the en25q32 which
is from the same family.
I have put the submitter of patch in CC, maybe he can test with the
SECT_4K set.
Thanks,
John
prev parent reply other threads:[~2012-08-29 11:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-26 8:37 [PATCH] mtd: m25p80: add support for the EON EN25Q64 chip Gabor Juhos
2012-08-29 11:04 ` Artem Bityutskiy
2012-08-29 11:13 ` John Crispin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=503DF956.6030308@openwrt.org \
--to=blogic@openwrt.org \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=emong@vip.qq.com \
--cc=juhosg@openwrt.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.