From: Haggai Eran <haggaie@mellanox.com>
To: David Rientjes <rientjes@google.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>, Pekka Enberg <penberg@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Or Gerlitz <ogerlitz@mellanox.com>,
Shachar Raindel <raindel@mellanox.com>
Subject: Re: [patch v3.6] mm, slab: lock the correct nodelist after reenabling irqs
Date: Wed, 29 Aug 2012 14:41:40 +0300 [thread overview]
Message-ID: <503DFFF4.4060909@mellanox.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1208281947100.24229@chino.kir.corp.google.com>
On 29/08/2012 05:57, David Rientjes wrote:
> On Tue, 28 Aug 2012, Haggai Eran wrote:
>
>> Hi,
>>
>> I believe I have encountered a bug in kernel 3.6-rc3. It starts with the
>> assertion in mm/slab.c:2629 failing, and then the system hangs. I can
>> reproduce this bug by running a large compilation (compiling the kernel
>> for instance).
>>
>> Here's what I see in netconsole:
>>> ------------[ cut here ]------------
>>> kernel BUG at mm/slab.c:2629!
>>> invalid opcode: 0000 [#1] SMP DEBUG_PAGEALLOC
>> I'm attaching netconsole logs I got with kernel 3.6-rc1, which contain a
>> little more details after the crash, but for some reason netconsole
>> didn't capture the full stack trace of the assertion. I caught a glimpse
>> at the console and I saw RIP was at cache_alloc_refill.
>>
> It only gets called from cache_alloc_refill().
>
> Looks like a problem in 072bb0aa5e0 ("mm: sl[au]b: add knowledge of
> PFMEMALLOC reserve pages"). cache_grow() can reenable irqs which allows
> this to be scheduled on a different cpu, possibly with a different node.
> So it turns out that we lock the wrong node's list_lock because we don't
> check the new node id when irqs are disabled again.
>
> I doubt you can reliably reproduce this, but the following should fix the
> issue.
Your patch did solve the issue. Thanks!
next prev parent reply other threads:[~2012-08-29 11:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-28 10:46 Kernel 3.6-rc3 BUG at mm/slab.c:2629 Haggai Eran
2012-08-29 2:57 ` [patch v3.6] mm, slab: lock the correct nodelist after reenabling irqs David Rientjes
2012-08-29 11:41 ` Haggai Eran [this message]
2012-08-30 10:15 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=503DFFF4.4060909@mellanox.com \
--to=haggaie@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=ogerlitz@mellanox.com \
--cc=penberg@kernel.org \
--cc=raindel@mellanox.com \
--cc=rientjes@google.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.