From: David Ahern <dsahern@gmail.com>
To: Irina Tirdea <irina.tirdea@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Ingo Molnar <mingo@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH 12/13] perf tools: replace on_exit with atexit
Date: Wed, 29 Aug 2012 10:59:04 -0600 [thread overview]
Message-ID: <503E4A58.5000000@gmail.com> (raw)
In-Reply-To: <CANg8OW+q0VumrJrQL57gecO0W0TrpB_WgspKhM-GeiPEdiSPDQ@mail.gmail.com>
On 8/28/12 4:06 PM, Irina Tirdea wrote:
> on_exit() is only available in new versions of glibc.
> Using on_exit on Android leads to errors at compile time.
>
> Replacing on_exit with its more portable version atexit.
> This leads to using a global variable since on_exit supports
> sending a parameters while atexit does not.
Bernhard's patch implements on_exit. Why not go that route?
The exit functions need the commands status to know whether to attempt
to process records. See: https://lkml.org/lkml/2012/8/26/123
Processing records on non-0 exit causes a segfault as the session has
been deleted.
David
next prev parent reply other threads:[~2012-08-29 16:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-28 22:06 [PATCH 12/13] perf tools: replace on_exit with atexit Irina Tirdea
2012-08-29 16:59 ` David Ahern [this message]
2012-09-02 20:30 ` Irina Tirdea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=503E4A58.5000000@gmail.com \
--to=dsahern@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@ghostprotocols.net \
--cc=fweisbec@gmail.com \
--cc=irina.tirdea@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.