From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Pilcher Subject: Re: -next queue and EDID stuff Date: Wed, 29 Aug 2012 14:53:03 -0500 Message-ID: <503E731F.2020303@gmail.com> References: <503BD762.6070204@redhat.com> <503D553C.9000503@gmail.com> <503D5EB9.2040405@redhat.com> <503D9810.60104@gmail.com> <20120829075616.GA5278@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-yw0-f53.google.com (mail-yw0-f53.google.com [209.85.213.53]) by gabe.freedesktop.org (Postfix) with ESMTP id 235CA9EC8B for ; Wed, 29 Aug 2012 12:53:06 -0700 (PDT) Received: by yhp3 with SMTP id 3so214160yhp.26 for ; Wed, 29 Aug 2012 12:53:05 -0700 (PDT) In-Reply-To: <20120829075616.GA5278@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Daniel Vetter , Adam Jackson Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On 08/29/2012 02:56 AM, Daniel Vetter wrote: > Wrt intel infoframes issues: Have you retested on latest 3.6-rc kernels? > We've fixed quite a few bugs for our infoframe support recently ... Tested just now. The behavior has changed. I now need to use *both* flags to make my display work with an Intel GPU. (Previously, the NO_AUDIO flag was sufficient to make the display work with Intel graphics.) Presumably, the Intel driver is now sending AVI InfoFrames. Thinking a bit more about this, I'm starting to rethink my assertion that the Intel driver is at fault here. On one hand, it doesn't make any sense to send audio InfoFrames to a non-HDMI display. (BTW, I'm assuming that a display with a DisplayPort port will show up as HDMI.) On the other hand, it can be argued that the DRM layer is giving conflicting information to the driver -- drm_detect_hdmi_monitor is returning FALSE, but drm_detect_monitor_audio is returning TRUE. AFAIK, this doesn't make any sense either. This leads me to propose that drm_detect_monitor_audio return FALSE if either EDID_QUIRK_DISABLE_INFOFRAMES or EDID_QUIRK_NO_AUDIO is set. bool drm_detect_monitor_audio(struct edid *edid) { u8 *edid_ext; int i, j; bool has_audio = false; int start_offset, end_offset; char buf[EDID_DISPLAY_ID_BUF_SIZE]; if (edid_get_quirks(edid) & (EDID_QUIRK_NO_AUDIO | EDID_QUIRK_DISABLE_INFOFRAMES)) { DRM_INFO("Disabling HDMI audio on display %s " "due to EDID quirk\n", drm_edid_display_id_format(edid->display_id, buf, 1)); goto end; } ... EDID_QUIRK_DISABLE_INFOFRAMES would then be sufficient to make the LG L246WP work with both nVidia and Intel GPUs. (ATI GPUs should work as well; I just don't have any hardware to test.) Ajax - Does this address your objections? If so, I'll spin another patch set. Thanks! -- ======================================================================== Ian Pilcher arequipeno@gmail.com "If you're going to shift my paradigm ... at least buy me dinner first." ========================================================================