From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Wed, 29 Aug 2012 23:49:03 +0200 (CEST) Received: from avon.wwwdotorg.org ([70.85.31.133]:53311 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S1903257Ab2H2Vsz (ORCPT ); Wed, 29 Aug 2012 23:48:55 +0200 Received: from severn.wwwdotorg.org (unknown [192.168.65.5]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by avon.wwwdotorg.org (Postfix) with ESMTPS id 403F0625C; Wed, 29 Aug 2012 15:56:15 -0600 (MDT) Received: from springbank2.nvidia.com (unknown [38.96.16.75]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by severn.wwwdotorg.org (Postfix) with ESMTPSA id 0CA4FE40E5; Wed, 29 Aug 2012 15:48:48 -0600 (MDT) Message-ID: <503E8E6E.1010101@wwwdotorg.org> Date: Wed, 29 Aug 2012 14:49:34 -0700 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux armv7l; rv:14.0) Gecko/20120713 Thunderbird/14.0 MIME-Version: 1.0 To: Mark Brown CC: Arnd Bergmann , Russell King , Haavard Skinnemoen , Hans-Christian Egtvedt , Ralf Baechle , Benjamin Herrenschmidt , Paul Mackerras , Guan Xuetao , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@linux-mips.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH] clk: Make the generic clock API available by default References: <1346186104-4083-1-git-send-email-broonie@opensource.wolfsonmicro.com> In-Reply-To: <1346186104-4083-1-git-send-email-broonie@opensource.wolfsonmicro.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.96.5 at avon.wwwdotorg.org X-Virus-Status: Clean X-archive-position: 34376 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: swarren@wwwdotorg.org Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips Return-Path: On 08/28/12 13:35, Mark Brown wrote: > Rather than requiring platforms to select the generic clock API to make > it available make the API available as a user selectable option unless the > user either selects HAVE_CUSTOM_CLK (if they have their own implementation) > or selects COMMON_CLK (if they depend on the generic implementation). > > All current architectures that HAVE_CLK but don't use the common clock > framework have selects of HAVE_CUSTOM_CLK added. > > This allows drivers to use the generic API on platforms which have no need > for the clock API at platform level. > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > @@ -674,6 +676,7 @@ config ARCH_TEGRA > select GENERIC_CLOCKEVENTS > select GENERIC_GPIO > select HAVE_CLK > + select HAVE_CUSTOM_CLK For 3.7, Tegra will switch to the common clock framework. I think this patch would then disable that. How should we resolve this - rebase the Tegra common-clk tree on top of any branch containing this patch in order to remove that select statement? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from avon.wwwdotorg.org (avon.wwwdotorg.org [IPv6:2001:470:1f0f:bd7::2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id A9C892C010F for ; Thu, 30 Aug 2012 07:59:02 +1000 (EST) Message-ID: <503E8E6E.1010101@wwwdotorg.org> Date: Wed, 29 Aug 2012 14:49:34 -0700 From: Stephen Warren MIME-Version: 1.0 To: Mark Brown Subject: Re: [PATCH] clk: Make the generic clock API available by default References: <1346186104-4083-1-git-send-email-broonie@opensource.wolfsonmicro.com> In-Reply-To: <1346186104-4083-1-git-send-email-broonie@opensource.wolfsonmicro.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: linux-mips@linux-mips.org, Guan Xuetao , Russell King , Arnd Bergmann , linux-kernel@vger.kernel.org, Ralf Baechle , Paul Mackerras , Haavard Skinnemoen , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, Hans-Christian Egtvedt List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 08/28/12 13:35, Mark Brown wrote: > Rather than requiring platforms to select the generic clock API to make > it available make the API available as a user selectable option unless the > user either selects HAVE_CUSTOM_CLK (if they have their own implementation) > or selects COMMON_CLK (if they depend on the generic implementation). > > All current architectures that HAVE_CLK but don't use the common clock > framework have selects of HAVE_CUSTOM_CLK added. > > This allows drivers to use the generic API on platforms which have no need > for the clock API at platform level. > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > @@ -674,6 +676,7 @@ config ARCH_TEGRA > select GENERIC_CLOCKEVENTS > select GENERIC_GPIO > select HAVE_CLK > + select HAVE_CUSTOM_CLK For 3.7, Tegra will switch to the common clock framework. I think this patch would then disable that. How should we resolve this - rebase the Tegra common-clk tree on top of any branch containing this patch in order to remove that select statement? From mboxrd@z Thu Jan 1 00:00:00 1970 From: swarren@wwwdotorg.org (Stephen Warren) Date: Wed, 29 Aug 2012 14:49:34 -0700 Subject: [PATCH] clk: Make the generic clock API available by default In-Reply-To: <1346186104-4083-1-git-send-email-broonie@opensource.wolfsonmicro.com> References: <1346186104-4083-1-git-send-email-broonie@opensource.wolfsonmicro.com> Message-ID: <503E8E6E.1010101@wwwdotorg.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 08/28/12 13:35, Mark Brown wrote: > Rather than requiring platforms to select the generic clock API to make > it available make the API available as a user selectable option unless the > user either selects HAVE_CUSTOM_CLK (if they have their own implementation) > or selects COMMON_CLK (if they depend on the generic implementation). > > All current architectures that HAVE_CLK but don't use the common clock > framework have selects of HAVE_CUSTOM_CLK added. > > This allows drivers to use the generic API on platforms which have no need > for the clock API at platform level. > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig > @@ -674,6 +676,7 @@ config ARCH_TEGRA > select GENERIC_CLOCKEVENTS > select GENERIC_GPIO > select HAVE_CLK > + select HAVE_CUSTOM_CLK For 3.7, Tegra will switch to the common clock framework. I think this patch would then disable that. How should we resolve this - rebase the Tegra common-clk tree on top of any branch containing this patch in order to remove that select statement?