All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanha@gmail.com,
	qemu-devel@nongnu.org, blauwirbel@gmail.com, eblake@redhat.com,
	afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH v3 2/5] [RFC] libqblock, user example
Date: Thu, 30 Aug 2012 09:59:20 +0800	[thread overview]
Message-ID: <503EC8F8.4020906@linux.vnet.ibm.com> (raw)
In-Reply-To: <503DF8EB.3080507@redhat.com>

于 2012-8-29 19:11, Paolo Bonzini 写道:
> Il 29/08/2012 13:05, Wenchao Xia ha scritto:
>> +    printf("checking aio status for %d times.\n", check_times);
>> +    while (true == qb_aio_check(broker)) {
>> +        check_times++;
>> +        usleep(1);
>> +    }
>> +
>
> Busy waiting is not acceptable, and this is the reason why I had
> suggested to keep AIO out of the design for now.
>
> You need to provide an implementation of AIO for either glib or
> something else, but this is best done within QEMU first (and only later
> moved to libqblock).
>
   It is similar to qemu's "select" type of AIO, while (true ==
qb_aio_check(broker) is not neccessary but an example here
to ensure write i/o is executed first.
   Do you mean qemu's aio should be improved to another type of
AIO API instead of select type? which kind of AIO api is preferred?

> Paolo
>


-- 
Best Regards

Wenchao Xia

  reply	other threads:[~2012-08-30  2:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-29 11:05 [Qemu-devel] [PATCH v3 2/5] [RFC] libqblock, user example Wenchao Xia
2012-08-29 11:11 ` Paolo Bonzini
2012-08-30  1:59   ` Wenchao Xia [this message]
2012-08-30  7:46     ` Paolo Bonzini
2012-08-31  2:38       ` Wenchao Xia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=503EC8F8.4020906@linux.vnet.ibm.com \
    --to=xiawenc@linux.vnet.ibm.com \
    --cc=afaerber@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=blauwirbel@gmail.com \
    --cc=eblake@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.