Re: [PATCH] telit: enable extended sim status notification

[Denis Kenzior <denkenz@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1548 bytes --]

Hi Christopher,

On 08/29/2012 10:01 AM, Christopher Vogl wrote:
> Use AT#QSS=2 instead of AT#QSS=1 to get an URC when the SIM is not only
> inserted but also when PIN is unlocked and when SMS + phonebook are
> ready to be used.
>
> Disable sim state notification in telit_enable() so that we sure get a
> notification when we enable it later again. This way we don't have to
> query the state the first time. Without this the Telit modem does not
> always send an URC when AT#QSS=2 is sent.
>
> Remove sim_inserted_source and sim_inserted_timeout_cb which are not
> needed anymore as a consequence.
> By the way the 1 second timeout was an ugly hack.
>
> Don't query current SIM status in cfun_enable_cb() as the SIM is
> disabled due to prior AT+CFUN=4.
>
> Register '#QSS:' before enabling sim state notifications.
>
> Remove telit_qss_cb() which was used as a callback for querying the
> current SIM status.
>
> Move sms atom creation into switch_sim_state_status() and add creation
> of phonebook atom. These are created when QSS: 3 is received.
>
> Avoid a reset  when switching between online and offline (airplane)
> mode in telit_set_online(). +CFUN accepts a second parameter (0), which
> disables a reset: AT+CFUN=x,0.
> ---
>   plugins/telit.c |   99 +++++++++++++++++++-----------------------------------
>   1 files changed, 35 insertions(+), 64 deletions(-)
>

Patch has been applied, however I broke it up into two.  One for the 
extra CFUN parameter changes and the rest.

Regards,
-Denis