From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adam Jackson Subject: Re: [PATCH] drm/i915/hdmi: only enable audio if there's a hdmi sink Date: Thu, 30 Aug 2012 11:32:34 -0400 Message-ID: <503F8792.5050006@redhat.com> References: <1346312676-17857-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1346312676-17857-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: stable@vger.kernel.org, Intel Graphics Development , Ian Pilcher , DRI Development List-Id: dri-devel@lists.freedesktop.org On 8/30/12 3:44 AM, Daniel Vetter wrote: > Some monitors totally don't like to receive infoframes, and naturally > don't claim to support hdmi. > > But for some odd reason they've added a CEA block to their edid, > which automatically gives you basic audio. Still, we may not send > out hdmi infoframes to them, hence check whether the sink is indeed > hdmi capable. > > Also kill a stale comment while at it. Does an incomplete version of what it says on the box, you need to hit the HDMI code in intel_sdvo.c too. At which point, should do the obvious bool drm_monitor_has_hdmi_audio() in drm_edid.c. - ajax