From: Saul Wold <sgw@linux.intel.com>
To: Ross Burton <ross.burton@intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] glib-2.0: don't disable all debugging functionality
Date: Fri, 31 Aug 2012 09:07:12 -0700 [thread overview]
Message-ID: <5040E130.3040102@linux.intel.com> (raw)
In-Reply-To: <1346338319-17685-1-git-send-email-ross.burton@intel.com>
On 08/30/2012 07:51 AM, Ross Burton wrote:
> GLib will use "minimal" debugging on non-development builds and the extra safety
> net and ability to debug at all is totally worth the small performance cost.
>
> If someone has a need for every ounce of performance, a simple .bbappend can
> restore this option.
>
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
> meta/recipes-core/glib-2.0/glib-2.0_2.32.4.bb | 2 +-
> meta/recipes-core/glib-2.0/glib.inc | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-core/glib-2.0/glib-2.0_2.32.4.bb b/meta/recipes-core/glib-2.0/glib-2.0_2.32.4.bb
> index 8f7cd69..7bc97d68 100644
> --- a/meta/recipes-core/glib-2.0/glib-2.0_2.32.4.bb
> +++ b/meta/recipes-core/glib-2.0/glib-2.0_2.32.4.bb
> @@ -1,6 +1,6 @@
> require glib.inc
>
> -PR = "r4"
> +PR = "r5"
> PE = "1"
>
> DEPENDS += "libffi python-argparse-native zlib"
> diff --git a/meta/recipes-core/glib-2.0/glib.inc b/meta/recipes-core/glib-2.0/glib.inc
> index 3540cd5..9dca440 100644
> --- a/meta/recipes-core/glib-2.0/glib.inc
> +++ b/meta/recipes-core/glib-2.0/glib.inc
> @@ -27,7 +27,7 @@ S = "${WORKDIR}/glib-${PV}"
>
> CORECONF = "--disable-dtrace --disable-fam --disable-libelf --disable-systemtap"
>
> -EXTRA_OECONF = "--disable-debug --enable-included-printf=no ${CORECONF}"
> +EXTRA_OECONF = "--enable-included-printf=no ${CORECONF}"
> EXTRA_OECONF_virtclass-native = "${CORECONF}"On 08/30/2012 07:51 AM, Ross Burton wrote:> GLib will use "minimal" debugging on non-development builds and the extra safety
> net and ability to debug at all is totally worth the small performance cost.
>
> If someone has a need for every ounce of performance, a simple .bbappend can
> restore this option.
>
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
> meta/recipes-core/glib-2.0/glib-2.0_2.32.4.bb | 2 +-
> meta/recipes-core/glib-2.0/glib.inc | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-core/glib-2.0/glib-2.0_2.32.4.bb b/meta/recipes-core/glib-2.0/glib-2.0_2.32.4.bb
> index 8f7cd69..7bc97d68 100644
> --- a/meta/recipes-core/glib-2.0/glib-2.0_2.32.4.bb
> +++ b/meta/recipes-core/glib-2.0/glib-2.0_2.32.4.bb
> @@ -1,6 +1,6 @@
> require glib.inc
>
> -PR = "r4"
> +PR = "r5"
> PE = "1"
>
> DEPENDS += "libffi python-argparse-native zlib"
> diff --git a/meta/recipes-core/glib-2.0/glib.inc b/meta/recipes-core/glib-2.0/glib.inc
> index 3540cd5..9dca440 100644
> --- a/meta/recipes-core/glib-2.0/glib.inc
> +++ b/meta/recipes-core/glib-2.0/glib.inc
> @@ -27,7 +27,7 @@ S = "${WORKDIR}/glib-${PV}"
>
> CORECONF = "--disable-dtrace --disable-fam --disable-libelf --disable-systemtap"
>
> -EXTRA_OECONF = "--disable-debug --enable-included-printf=no ${CORECONF}"
> +EXTRA_OECONF = "--enable-included-printf=no ${CORECONF}"
> EXTRA_OECONF_virtclass-native = "${CORECONF}"
> EXTRA_OECONF_linuxstdbase = "--enable-included-printf=no ${CORECONF}"
>
>
> EXTRA_OECONF_linuxstdbase = "--enable-included-prinOn 08/30/2012 07:51 AM, Ross Burton wrote:> GLib will use "minimal" debugging on non-development builds and the extra safety
> net and ability to debug at all is totally worth the small performance cost.
>
> If someone has a need for every ounce of performance, a simple .bbappend can
> restore this option.
>
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
> meta/recipes-core/glib-2.0/glib-2.0_2.32.4.bb | 2 +-
> meta/recipes-core/glib-2.0/glib.inc | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-core/glib-2.0/glib-2.0_2.32.4.bb b/meta/recipes-core/glib-2.0/glib-2.0_2.32.4.bb
> index 8f7cd69..7bc97d68 100644
> --- a/meta/recipes-core/glib-2.0/glib-2.0_2.32.4.bb
> +++ b/meta/recipes-core/glib-2.0/glib-2.0_2.32.4.bb
> @@ -1,6 +1,6 @@
> require glib.inc
>
> -PR = "r4"
> +PR = "r5"
> PE = "1"
>
> DEPENDS += "libffi python-argparse-native zlib"
> diff --git a/meta/recipes-core/glib-2.0/glib.inc b/meta/recipes-core/glib-2.0/glib.inc
> index 3540cd5..9dca440 100644
> --- a/meta/recipes-core/glib-2.0/glib.inc
> +++ b/meta/recipes-core/glib-2.0/glib.inc
> @@ -27,7 +27,7 @@ S = "${WORKDIR}/glib-${PV}"
>
> CORECONF = "--disable-dtrace --disable-fam --disable-libelf --disable-systemtap"
>
> -EXTRA_OECONF = "--disable-debug --enable-included-printf=no ${CORECONF}"
> +EXTRA_OECONF = "--enable-included-printf=no ${CORECONF}"
> EXTRA_OECONF_virtclass-native = "${CORECONF}"
> EXTRA_OECONF_linuxstdbase = "--enable-included-printf=no ${CORECONF}"
>
> tf=no ${CORECONF}"
>
>
Merged into OE-Core
Thanks
Sau!
prev parent reply other threads:[~2012-08-31 16:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-30 14:51 [PATCH] glib-2.0: don't disable all debugging functionality Ross Burton
2012-08-31 16:07 ` Saul Wold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5040E130.3040102@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.