From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Vrabel <david.vrabel@citrix.com>
Subject: Re: [PATCH] Xen backend support for paged out grant
	targets.
Date: Fri, 31 Aug 2012 17:10:56 +0100
Message-ID: <5040E210.2060702@citrix.com>
References: <1346086287-17674-1-git-send-email-andres@lagarcavilla.org>
	<5040CAEA.7000600@citrix.com>
	<160CC375-2682-4CBF-B1EC-06A9F3E49A40@gridcentric.ca>
	<A976B10C-58BE-4660-89E9-A8F85CAB5F19@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <A976B10C-58BE-4660-89E9-A8F85CAB5F19@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Andres Lagar-Cavilla <andres.lagarcavilla@gmail.com>
Cc: Andres Lagar-Cavilla <andreslc@gridcentric.ca>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, "andres@lagarcavilla.org" <andres@lagarcavilla.org>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 31/08/12 16:42, Andres Lagar-Cavilla wrote:
> Actually acted upon your feedback ipso facto:
> 
> commit d5fab912caa1f0cf6be0a6773f502d3417a207b6
> Author: Andres Lagar-Cavilla <andres@lagarcavilla.org>
> Date:   Sun Aug 26 09:45:57 2012 -0400
> 
>     Xen backend support for paged out grant targets.

This looks mostly fine expect for the #define instead of inline functions.

> +#define gnttab_map_grant_no_eagain(_gop)                                    \

This name tripped me up previously. As I read this as:

gnttab_map_grant_no_[retries_for]_eagain().

Perhaps gnttab_map_grant_with_retries() ? Or similar?

David