From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sekhar Nori Subject: Re: [PATCH v3 3/3] spi: spi-davinci: convert to DMA engine API Date: Fri, 31 Aug 2012 22:01:03 +0530 Message-ID: <5040E6C7.6030106@ti.com> References: <1345684176-21472-1-git-send-email-mporter@ti.com> <1345684176-21472-4-git-send-email-mporter@ti.com> <503F75C0.1050507@ti.com> <20120830144307.GA26737@beef> <5040E00A.3080600@ti.com> <1346430709.15463.15.camel@vkoul-mobl4> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1346430709.15463.15.camel@vkoul-mobl4> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Vinod Koul Cc: Matt Porter , List , vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, Linux MMC List , Linux Kernel Mailing List Linux, List , cjb-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org, Kernel List List-Id: linux-mmc@vger.kernel.org On 8/31/2012 10:01 PM, Vinod Koul wrote: > On Fri, 2012-08-31 at 21:32 +0530, Sekhar Nori wrote: >> Hi Matt, >> >> On 8/30/2012 8:13 PM, Matt Porter wrote: >>> On Thu, Aug 30, 2012 at 07:46:32PM +0530, Sekhar Nori wrote: >>>> Hi Matt, >>>> >>>> On 8/23/2012 6:39 AM, Matt Porter wrote: >>>>> Removes use of the DaVinci EDMA private DMA API and replaces >>>>> it with use of the DMA engine API. >>>>> >>>>> Signed-off-by: Matt Porter >>>> >>>> I tried testing this patch on my OMAP-L138 EVM, but SPI fails to >>>> initialize after applying the patch. >>>> >>>> root@arago:~# dmesg | grep -i spi >>>> spi_davinci spi_davinci.1: request RX DMA channel failed >>> >>> Hi Sekhar, >>> >>> Most likely CONFIG_TI_EDMA is off as it defaults to off in the v3 >>> series. Try enabling this and if it's the problem then this error >>> path can be fixed to properly fallback to PIO only or fail to >>> initialize as needed. >> >> Yes, this was the problem. Since the SPI driver now depends on >> CONFIG_TI_EDMA for basic operation may be select CONFIG_TI_EDMA in >> Kconfig if SPI is enabled? That should do until the fallback to PIO is >> implemented. > Then this should be enabled for SPI. Care to send a patch By 'this' you mean the Kconfig select? Then there should be no need of a new patch for this. It can be part of this patch itself, no? Thanks, Sekhar ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sekhar Nori Subject: Re: [PATCH v3 3/3] spi: spi-davinci: convert to DMA engine API Date: Fri, 31 Aug 2012 22:01:03 +0530 Message-ID: <5040E6C7.6030106@ti.com> References: <1345684176-21472-1-git-send-email-mporter@ti.com> <1345684176-21472-4-git-send-email-mporter@ti.com> <503F75C0.1050507@ti.com> <20120830144307.GA26737@beef> <5040E00A.3080600@ti.com> <1346430709.15463.15.camel@vkoul-mobl4> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Matt Porter , List , vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, Linux MMC List , Linux Kernel Mailing List , Linux, List , cjb-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org, Kernel List To: Vinod Koul Return-path: In-Reply-To: <1346430709.15463.15.camel@vkoul-mobl4> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On 8/31/2012 10:01 PM, Vinod Koul wrote: > On Fri, 2012-08-31 at 21:32 +0530, Sekhar Nori wrote: >> Hi Matt, >> >> On 8/30/2012 8:13 PM, Matt Porter wrote: >>> On Thu, Aug 30, 2012 at 07:46:32PM +0530, Sekhar Nori wrote: >>>> Hi Matt, >>>> >>>> On 8/23/2012 6:39 AM, Matt Porter wrote: >>>>> Removes use of the DaVinci EDMA private DMA API and replaces >>>>> it with use of the DMA engine API. >>>>> >>>>> Signed-off-by: Matt Porter >>>> >>>> I tried testing this patch on my OMAP-L138 EVM, but SPI fails to >>>> initialize after applying the patch. >>>> >>>> root@arago:~# dmesg | grep -i spi >>>> spi_davinci spi_davinci.1: request RX DMA channel failed >>> >>> Hi Sekhar, >>> >>> Most likely CONFIG_TI_EDMA is off as it defaults to off in the v3 >>> series. Try enabling this and if it's the problem then this error >>> path can be fixed to properly fallback to PIO only or fail to >>> initialize as needed. >> >> Yes, this was the problem. Since the SPI driver now depends on >> CONFIG_TI_EDMA for basic operation may be select CONFIG_TI_EDMA in >> Kconfig if SPI is enabled? That should do until the fallback to PIO is >> implemented. > Then this should be enabled for SPI. Care to send a patch By 'this' you mean the Kconfig select? Then there should be no need of a new patch for this. It can be part of this patch itself, no? Thanks, Sekhar ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ From mboxrd@z Thu Jan 1 00:00:00 1970 From: nsekhar@ti.com (Sekhar Nori) Date: Fri, 31 Aug 2012 22:01:03 +0530 Subject: [PATCH v3 3/3] spi: spi-davinci: convert to DMA engine API In-Reply-To: <1346430709.15463.15.camel@vkoul-mobl4> References: <1345684176-21472-1-git-send-email-mporter@ti.com> <1345684176-21472-4-git-send-email-mporter@ti.com> <503F75C0.1050507@ti.com> <20120830144307.GA26737@beef> <5040E00A.3080600@ti.com> <1346430709.15463.15.camel@vkoul-mobl4> Message-ID: <5040E6C7.6030106@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 8/31/2012 10:01 PM, Vinod Koul wrote: > On Fri, 2012-08-31 at 21:32 +0530, Sekhar Nori wrote: >> Hi Matt, >> >> On 8/30/2012 8:13 PM, Matt Porter wrote: >>> On Thu, Aug 30, 2012 at 07:46:32PM +0530, Sekhar Nori wrote: >>>> Hi Matt, >>>> >>>> On 8/23/2012 6:39 AM, Matt Porter wrote: >>>>> Removes use of the DaVinci EDMA private DMA API and replaces >>>>> it with use of the DMA engine API. >>>>> >>>>> Signed-off-by: Matt Porter >>>> >>>> I tried testing this patch on my OMAP-L138 EVM, but SPI fails to >>>> initialize after applying the patch. >>>> >>>> root at arago:~# dmesg | grep -i spi >>>> spi_davinci spi_davinci.1: request RX DMA channel failed >>> >>> Hi Sekhar, >>> >>> Most likely CONFIG_TI_EDMA is off as it defaults to off in the v3 >>> series. Try enabling this and if it's the problem then this error >>> path can be fixed to properly fallback to PIO only or fail to >>> initialize as needed. >> >> Yes, this was the problem. Since the SPI driver now depends on >> CONFIG_TI_EDMA for basic operation may be select CONFIG_TI_EDMA in >> Kconfig if SPI is enabled? That should do until the fallback to PIO is >> implemented. > Then this should be enabled for SPI. Care to send a patch By 'this' you mean the Kconfig select? Then there should be no need of a new patch for this. It can be part of this patch itself, no? Thanks, Sekhar From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754261Ab2HaQbj (ORCPT ); Fri, 31 Aug 2012 12:31:39 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:33102 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753945Ab2HaQbh (ORCPT ); Fri, 31 Aug 2012 12:31:37 -0400 Message-ID: <5040E6C7.6030106@ti.com> Date: Fri, 31 Aug 2012 22:01:03 +0530 From: Sekhar Nori User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:15.0) Gecko/20120824 Thunderbird/15.0 MIME-Version: 1.0 To: Vinod Koul CC: , Matt Porter , Linux DaVinci Kernel List , Linux MMC List , Linux Kernel Mailing List , , Linux SPI Devel List , , Linux ARM Kernel List Subject: Re: [PATCH v3 3/3] spi: spi-davinci: convert to DMA engine API References: <1345684176-21472-1-git-send-email-mporter@ti.com> <1345684176-21472-4-git-send-email-mporter@ti.com> <503F75C0.1050507@ti.com> <20120830144307.GA26737@beef> <5040E00A.3080600@ti.com> <1346430709.15463.15.camel@vkoul-mobl4> In-Reply-To: <1346430709.15463.15.camel@vkoul-mobl4> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/31/2012 10:01 PM, Vinod Koul wrote: > On Fri, 2012-08-31 at 21:32 +0530, Sekhar Nori wrote: >> Hi Matt, >> >> On 8/30/2012 8:13 PM, Matt Porter wrote: >>> On Thu, Aug 30, 2012 at 07:46:32PM +0530, Sekhar Nori wrote: >>>> Hi Matt, >>>> >>>> On 8/23/2012 6:39 AM, Matt Porter wrote: >>>>> Removes use of the DaVinci EDMA private DMA API and replaces >>>>> it with use of the DMA engine API. >>>>> >>>>> Signed-off-by: Matt Porter >>>> >>>> I tried testing this patch on my OMAP-L138 EVM, but SPI fails to >>>> initialize after applying the patch. >>>> >>>> root@arago:~# dmesg | grep -i spi >>>> spi_davinci spi_davinci.1: request RX DMA channel failed >>> >>> Hi Sekhar, >>> >>> Most likely CONFIG_TI_EDMA is off as it defaults to off in the v3 >>> series. Try enabling this and if it's the problem then this error >>> path can be fixed to properly fallback to PIO only or fail to >>> initialize as needed. >> >> Yes, this was the problem. Since the SPI driver now depends on >> CONFIG_TI_EDMA for basic operation may be select CONFIG_TI_EDMA in >> Kconfig if SPI is enabled? That should do until the fallback to PIO is >> implemented. > Then this should be enabled for SPI. Care to send a patch By 'this' you mean the Kconfig select? Then there should be no need of a new patch for this. It can be part of this patch itself, no? Thanks, Sekhar