All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: linux-media@vger.kernel.org, Pawel Osciak <pawel@osciak.com>,
	Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: Re: [PATCH 2/2] media v4l2-mem2mem: fix src/out and dst/cap num_rdy
Date: Fri, 31 Aug 2012 20:35:32 +0200	[thread overview]
Message-ID: <504103F4.4000808@samsung.com> (raw)
In-Reply-To: <1346419084-10879-3-git-send-email-s.hauer@pengutronix.de>

Hello,

On 8/31/2012 3:18 PM, Sascha Hauer wrote:
> src bufs belong to out queue, dst bufs belong to in queue. Currently
> this is not a real problem since all users currently need exactly one
> input and one output buffer.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>

> ---
>   include/media/v4l2-mem2mem.h |    4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/media/v4l2-mem2mem.h b/include/media/v4l2-mem2mem.h
> index 16ac473..131cc4a 100644
> --- a/include/media/v4l2-mem2mem.h
> +++ b/include/media/v4l2-mem2mem.h
> @@ -140,7 +140,7 @@ void v4l2_m2m_buf_queue(struct v4l2_m2m_ctx *m2m_ctx, struct vb2_buffer *vb);
>   static inline
>   unsigned int v4l2_m2m_num_src_bufs_ready(struct v4l2_m2m_ctx *m2m_ctx)
>   {
> -	return m2m_ctx->cap_q_ctx.num_rdy;
> +	return m2m_ctx->out_q_ctx.num_rdy;
>   }
>
>   /**
> @@ -150,7 +150,7 @@ unsigned int v4l2_m2m_num_src_bufs_ready(struct v4l2_m2m_ctx *m2m_ctx)
>   static inline
>   unsigned int v4l2_m2m_num_dst_bufs_ready(struct v4l2_m2m_ctx *m2m_ctx)
>   {
> -	return m2m_ctx->out_q_ctx.num_rdy;
> +	return m2m_ctx->cap_q_ctx.num_rdy;
>   }
>
>   void *v4l2_m2m_next_buf(struct v4l2_m2m_queue_ctx *q_ctx);
>


Best regards
-- 
Marek Szyprowski
Samsung Poland R&D Center

  reply	other threads:[~2012-08-31 18:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-31 13:18 [PATCH] v4l2 mem2mem Sascha Hauer
2012-08-31 13:18 ` [PATCH 1/2] media v4l2-mem2mem: Use list_first_entry Sascha Hauer
2012-08-31 18:34   ` Marek Szyprowski
2012-09-01  1:28   ` Pawel Osciak
2012-08-31 13:18 ` [PATCH 2/2] media v4l2-mem2mem: fix src/out and dst/cap num_rdy Sascha Hauer
2012-08-31 18:35   ` Marek Szyprowski [this message]
2012-09-01  1:29   ` Pawel Osciak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=504103F4.4000808@samsung.com \
    --to=m.szyprowski@samsung.com \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@infradead.org \
    --cc=pawel@osciak.com \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.