From: Krzysztof Kozlowski <krzk@kernel.org>
To: Daniel Palmer <daniel@0x0f.com>,
krzk+dt@kernel.org, romain.perier@gmail.com, robh@kernel.org,
conor+dt@kernel.org, linux-arm-kernel@lists.infradead.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] arm: dts: mstar: breadbee: Correct regulator names
Date: Wed, 31 Dec 2025 10:49:39 +0100 [thread overview]
Message-ID: <50439d25-55a3-4d76-8864-81132db7598c@kernel.org> (raw)
In-Reply-To: <20251231025502.1139168-2-daniel@0x0f.com>
On 31/12/2025 03:54, Daniel Palmer wrote:
> The regulator names had a "@<n>" in them so the dt validation
> stuff wanted a reg property. Fix the names to match what the regulator
> is for and remove the "@<n>" bit.
>
> Signed-off-by: Daniel Palmer <daniel@0x0f.com>
> ---
> .../boot/dts/sigmastar/mstar-infinity-breadbee-common.dtsi | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/sigmastar/mstar-infinity-breadbee-common.dtsi b/arch/arm/boot/dts/sigmastar/mstar-infinity-breadbee-common.dtsi
> index 507ff2fba837..aedea0fbbce6 100644
> --- a/arch/arm/boot/dts/sigmastar/mstar-infinity-breadbee-common.dtsi
> +++ b/arch/arm/boot/dts/sigmastar/mstar-infinity-breadbee-common.dtsi
> @@ -7,7 +7,7 @@
> #include <dt-bindings/gpio/gpio.h>
>
> / {
> - vcc_core: fixedregulator@0 {
> + vcc_core: reg-core {
If renaming this then rather use one of the approved names, so either
"regulator-foo" or "regulator-XvY" (which matches current format
recommendation: 'regulator-[0-9]v[0-9]')
https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-12-31 9:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-31 2:54 [PATCH 0/5] Sigmastar DT warnings fixing part 1 Daniel Palmer
2025-12-31 2:54 ` [PATCH 1/5] arm: dts: mstar: breadbee: Correct regulator names Daniel Palmer
2025-12-31 9:49 ` Krzysztof Kozlowski [this message]
2025-12-31 2:54 ` [PATCH 2/5] arm: dts: mstar: breadbee: Correct LED names Daniel Palmer
2025-12-31 2:55 ` [PATCH 3/5] arm: dts: mstar: infinity: Correct opp table name Daniel Palmer
2025-12-31 7:47 ` Krzysztof Kozlowski
2025-12-31 8:35 ` Daniel Palmer
2025-12-31 9:48 ` Krzysztof Kozlowski
2025-12-31 10:17 ` Daniel Palmer
2026-01-02 10:03 ` Krzysztof Kozlowski
2025-12-31 2:55 ` [PATCH 4/5] arm: dts: mstar: v7: Move the reboot node Daniel Palmer
2025-12-31 2:55 ` [PATCH 5/5] arm: dts: mstar: v7: Add sizes and ranges to sram Daniel Palmer
2026-01-02 14:43 ` [PATCH 0/5] Sigmastar DT warnings fixing part 1 Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50439d25-55a3-4d76-8864-81132db7598c@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel@0x0f.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=romain.perier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.