From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] kvm/fpu: Enable fully eager restore kvm FPU Date: Mon, 03 Sep 2012 12:23:21 +0300 Message-ID: <50447709.4050108@redhat.com> References: <1345094044-28962-1-git-send-email-xudong.hao@intel.com> <502CB881.1040807@redhat.com> <403610A45A2B5242BD291EDAE8B37D300FE8AA17@SHSMSX102.ccr.corp.intel.com> <502CD276.7020403@redhat.com> <20120820092416.GB2582@amd.com> <50320C8E.6040109@redhat.com> <20120820101453.GF2582@amd.com> <503214BE.8050706@redhat.com> <403610A45A2B5242BD291EDAE8B37D300FEA6A0F@SHSMSX102.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "Roedel, Joerg" , "kvm@vger.kernel.org" , "Zhang, Xiantao" To: "Hao, Xudong" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:39343 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755574Ab2ICJX0 (ORCPT ); Mon, 3 Sep 2012 05:23:26 -0400 In-Reply-To: <403610A45A2B5242BD291EDAE8B37D300FEA6A0F@SHSMSX102.ccr.corp.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: On 08/23/2012 11:51 AM, Hao, Xudong wrote: >> -----Original Message----- >> From: kvm-owner@vger.kernel.org [mailto:kvm-owner@vger.kernel.org] On >> Behalf Of Avi Kivity >> Sent: Monday, August 20, 2012 6:43 PM >> To: Roedel, Joerg >> Cc: Hao, Xudong; kvm@vger.kernel.org; Zhang, Xiantao >> Subject: Re: [PATCH] kvm/fpu: Enable fully eager restore kvm FPU >> >> On 08/20/2012 01:14 PM, Roedel, Joerg wrote: >> > On Mon, Aug 20, 2012 at 01:08:14PM +0300, Avi Kivity wrote: >> >> On 08/20/2012 12:24 PM, Roedel, Joerg wrote: >> > >> >> So it was broken all along? Yikes. >> > >> > There is no LWP support in the kernel and thus KVM can't expose it to >> > guests. So for now nothing should be broken, no? >> >> Oh, we mask out xcr0 bits not supported by the host. >> >> So it's broken in another way: it isn't exposed. Pity, it's such a nice >> feature. >> > > Hi, Avi/Joerg > > What's the decision for it? I don't understand LWP, so how about this patch? It's fine (Joerg can send the LWP change), but there was a truncation issue that needs fixing, no? -- error compiling committee.c: too many arguments to function