From: Glauber Costa <glommer@parallels.com>
To: Christoph Lameter <cl@linux.com>
Cc: Pekka Enberg <penberg@kernel.org>, Joonsoo Kim <js1304@gmail.com>,
linux-mm@kvack.org, David Rientjes <rientjes@google.com>
Subject: Re: C13 [09/14] Move duping of slab name to slab_common.c
Date: Mon, 3 Sep 2012 19:02:54 +0400 [thread overview]
Message-ID: <5044C69E.3070704@parallels.com> (raw)
In-Reply-To: <00000139596ca258-6eb54dde-2278-4694-b562-5e02d5530419-000000@email.amazonses.com>
On 08/24/2012 08:17 PM, Christoph Lameter wrote:
> Duping of the slabname has to be done by each slab. Moving this code
> to slab_common avoids duplicate implementations.
>
> With this patch we have common string handling for all slab allocators.
> Strings passed to kmem_cache_create() are copied internally. Subsystems
> can create temporary strings to create slab caches.
>
> Slabs allocated in early states of bootstrap will never be freed (and those
> can never be freed since they are essential to slab allocator operations).
> During bootstrap we therefore do not have to worry about duping names.
>
> Signed-off-by: Christoph Lameter <cl@linux.com>
This version fixes all the problems I've raised before.
I've also boot-tested and applied my previous repeated
kmem_cache_destroy() test and it seems to survive well.
Reviewed-by: Glauber Costa <glommer@parallels.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-09-03 15:06 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120824160903.168122683@linux.com>
2012-08-24 16:10 ` C13 [05/14] Extract a common function for kmem_cache_destroy Christoph Lameter
2012-09-03 14:41 ` Glauber Costa
2012-09-03 15:26 ` Glauber Costa
2012-09-04 22:58 ` Christoph Lameter
2012-08-24 16:12 ` C13 [07/14] Move freeing of kmem_cache structure to common code Christoph Lameter
2012-09-03 14:51 ` Glauber Costa
2012-08-24 16:12 ` C13 [08/14] Get rid of __kmem_cache_destroy Christoph Lameter
2012-09-03 14:58 ` Glauber Costa
2012-09-04 22:39 ` Christoph Lameter
2012-09-05 8:25 ` Glauber Costa
2012-08-24 16:17 ` C13 [11/14] Move sysfs_slab_add to common Christoph Lameter
2012-09-03 15:09 ` Glauber Costa
2012-08-24 16:17 ` C13 [03/14] Improve error handling in kmem_cache_create Christoph Lameter
2012-09-03 14:30 ` Glauber Costa
2012-08-24 16:17 ` C13 [12/14] Move kmem_cache allocations into common code Christoph Lameter
2012-09-03 15:24 ` Glauber Costa
2012-08-24 16:17 ` C13 [06/14] Always use the name "kmem_cache" for the slab cache with the kmem_cache structure Christoph Lameter
2012-08-24 16:17 ` C13 [04/14] Move list_add() to slab_common.c Christoph Lameter
2012-08-24 16:17 ` C13 [10/14] Do slab aliasing call from common code Christoph Lameter
2012-08-24 16:17 ` C13 [09/14] Move duping of slab name to slab_common.c Christoph Lameter
2012-09-03 15:02 ` Glauber Costa [this message]
2012-08-24 16:17 ` C13 [01/14] slub: Add debugging to verify correct cache use on kmem_cache_free() Christoph Lameter
2012-09-03 14:26 ` Glauber Costa
2012-08-24 16:17 ` C13 [02/14] slub: Use kmem_cache for the kmem_cache structure Christoph Lameter
2012-09-03 14:27 ` Glauber Costa
2012-08-24 16:17 ` C13 [14/14] Move kmem_cache refcounting to common code Christoph Lameter
2012-09-03 15:12 ` Glauber Costa
2012-09-04 19:10 ` Christoph Lameter
2012-08-24 16:17 ` C13 [13/14] Shrink __kmem_cache_create() parameter lists Christoph Lameter
2012-09-03 15:33 ` Glauber Costa
2012-09-03 15:35 ` Glauber Costa
2012-09-04 22:48 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5044C69E.3070704@parallels.com \
--to=glommer@parallels.com \
--cc=cl@linux.com \
--cc=js1304@gmail.com \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.