From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:38718)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1T8YqE-0003dV-3Z
	for qemu-devel@nongnu.org; Mon, 03 Sep 2012 11:45:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1T8YqA-0007h2-0F
	for qemu-devel@nongnu.org; Mon, 03 Sep 2012 11:45:34 -0400
Received: from david.siemens.de ([192.35.17.14]:32982)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1T8Yq9-0007gx-M0
	for qemu-devel@nongnu.org; Mon, 03 Sep 2012 11:45:29 -0400
Message-ID: <5044D08F.9030303@siemens.com>
Date: Mon, 03 Sep 2012 17:45:19 +0200
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <1346640974-30974-1-git-send-email-mmogilvi_qemu@miniinfo.net>
	<1346640974-30974-6-git-send-email-mmogilvi_qemu@miniinfo.net>
	<50446D11.5050904@suse.de> <5044C10D.7050600@redhat.com>
	<87fw6z5d0e.fsf@elfo.mitica>
In-Reply-To: <87fw6z5d0e.fsf@elfo.mitica>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v4 5/5] i8259: fix dynamically masking
 slave IRQs with IMR register
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: quintela@redhat.com
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>, Matthew Ogilvie <mmogilvi_qemu@miniinfo.net>, Avi Kivity <avi@redhat.com>, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>

On 2012-09-03 17:42, Juan Quintela wrote:
> Avi Kivity <avi@redhat.com> wrote:
>> On 09/03/2012 11:40 AM, Andreas F=C3=A4rber wrote:
>>> Am 03.09.2012 04:56, schrieb Matthew Ogilvie:
>>>> diff --git a/hw/i8259_common.c b/hw/i8259_common.c
>>>> index ab3d98b..dcde5f2 100644
>>>> --- a/hw/i8259_common.c
>>>> +++ b/hw/i8259_common.c
>>> [...]
>>>> @@ -111,6 +112,7 @@ static const VMStateDescription vmstate_pic_comm=
on =3D {
>>>>          VMSTATE_UINT8(isr, PICCommonState),
>>>>          VMSTATE_UINT8(priority_add, PICCommonState),
>>>>          VMSTATE_UINT8(irq_base, PICCommonState),
>>>> +        VMSTATE_UINT8(icw3, PICCommonState),
>>>>          VMSTATE_UINT8(read_reg_select, PICCommonState),
>>>>          VMSTATE_UINT8(poll, PICCommonState),
>>>>          VMSTATE_UINT8(special_mask, PICCommonState),
>>>
>>> Additional VMState needs to be versioned by incrementing .version_id =
and
>>> by specifying the new version number here. Otherwise it breaks migrat=
ion.
>=20
> For the subsection, only sending this when icw3 !=3D 0 is enough?  I am
> searching for a test about when we need to send it.

See my reply on this topic in the other branch of this thread.

>=20
>> And incrementing the version ID breaks backwards migration.  The corre=
ct
>> solution is subsections, copying Juan and booking a trip to the Marian=
a
>> trench.
>=20
> Book also for me, no need for the return ticket.
>=20

Hey, this scenario is rather harmless (famous last words...). ;)

Jan

--=20
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux