From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Benoît <benoit@pouic.eu>
Cc: linux-can@vger.kernel.org
Subject: Re: [PATCH] can: mcp251x: avoid repeated frame bug
Date: Mon, 03 Sep 2012 19:59:52 +0200 [thread overview]
Message-ID: <5044F018.50808@pengutronix.de> (raw)
In-Reply-To: <5044E54F.7020507@pouic.eu>
[-- Attachment #1: Type: text/plain, Size: 1178 bytes --]
On 09/03/2012 07:13 PM, Benoît wrote:
[...]
>> Hello Benoit,
>>
>> can you please test this patch, if it still fixes your problem. In
>> order to
>> integrate this patch into the kernel, I need you Signed-off-by [1]
>> with you
>> real name.
>
> I just carefully ran some before/after tests with your updated patch and
> I confirm the problem is still fixed with it.
Thanks.
>
> As for my "Signed-off-by", here it goes:
>
> Signed-off-by: Benoît Locher <Benoit.Locher@skf.com>
I'll change the author of the patch to that address then.
> By the way, about using spi_write()instead of mcp251x_spi_trans(): I
> innocently thought it would make less function call nesting,
> trying to improve response time of the driver particularly on my
> Raspberry Pi.
Ahh, I see. but the mcp251x_spi_trans() function takes does the setup
thats needed for DMA.
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
next prev parent reply other threads:[~2012-09-03 17:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-03 12:17 [PATCH] can: mcp251x: avoid repeated frame bug Marc Kleine-Budde
2012-09-03 17:13 ` Benoît
2012-09-03 17:59 ` Marc Kleine-Budde [this message]
2012-09-03 18:09 ` Benoît
2012-09-05 19:59 ` Marc Kleine-Budde
-- strict thread matches above, loose matches on Subject: below --
2012-09-04 20:55 pull-request: can 2012-09-04 Marc Kleine-Budde
2012-09-04 20:55 ` [PATCH] can: mcp251x: avoid repeated frame bug Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5044F018.50808@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=benoit@pouic.eu \
--cc=linux-can@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.