From: Jonathan Cameron <jic23@kernel.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Jean-Francois Dagenais <jeff.dagenais@gmail.com>,
linux-iio@vger.kernel.org,
device-drivers-devel@blackfin.uclinux.org
Subject: Re: [PATCH v3.6-rc2 V2 1/2] iio:ad5446: Add support for I2C based DACs
Date: Mon, 03 Sep 2012 21:11:13 +0100 [thread overview]
Message-ID: <50450EE1.3020007@kernel.org> (raw)
In-Reply-To: <504463D5.6000104@metafoo.de>
On 09/03/2012 09:01 AM, Lars-Peter Clausen wrote:
> On 08/24/2012 01:38 PM, Lars-Peter Clausen wrote:
>> On 08/22/2012 08:24 PM, Jonathan Cameron wrote:
>>> On 08/21/2012 03:28 PM, Jean-Francois Dagenais wrote:
>>>> This patch adds support for I2C based single channel DACs to the ad5446
>>>> driver. Specifically AD5602, AD5612 and AD5622.
>>>>
>>>> V1: from Lars-Peter Clausen <lars@metafoo.de>
>>>> V2: Split the device IDs into two enums and move them to the c file.
>>> Sensible change. Patch is fine but given we are still well away from
>>> the merge window I'll wait for Lars-Peter's response before merging this.
>>>
>>
>> Looks good to me on first sight. I'd have done the two patches in reverse
>> order, but it doesn't really matter.
>>
>> Will take a closer look when I'm back from vacation, but I'm already quite
>> confident that it can go in as is.
>>
>
>
> Both patches:
> Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Merge and pull request sent to Greg.
Thanks.
next prev parent reply other threads:[~2012-09-03 20:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <502E10A4.1080800@metafoo.de>
2012-08-20 19:23 ` Jean-François Dagenais
2012-08-20 19:23 ` [PATCH] iio:ad5446: Add support for I2C based DACs Jean-François Dagenais
2012-08-21 13:17 ` Jean-François Dagenais
2012-08-21 14:28 ` [PATCH v3.6-rc2 V2 0/2] iio:ad5446: add I2C DACs and header cleanup Jean-Francois Dagenais
2012-08-21 14:28 ` [PATCH v3.6-rc2 V2 1/2] iio:ad5446: Add support for I2C based DACs Jean-Francois Dagenais
2012-08-22 18:24 ` Jonathan Cameron
2012-08-24 11:38 ` Lars-Peter Clausen
2012-09-03 8:01 ` Lars-Peter Clausen
2012-09-03 20:11 ` Jonathan Cameron [this message]
2012-08-21 14:28 ` [PATCH v3.6-rc2 V2 2/2] iio:ad5446: get rid of private header file Jean-Francois Dagenais
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50450EE1.3020007@kernel.org \
--to=jic23@kernel.org \
--cc=device-drivers-devel@blackfin.uclinux.org \
--cc=jeff.dagenais@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.