From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Bhanu Prakash Gollapudi" Subject: Re: [PATCH] Fix incorrect memset in bnx2fc_parse_fcp_rsp Date: Mon, 3 Sep 2012 18:21:41 -0700 Message-ID: <504557A5.1040500@broadcom.com> References: <20120903185030.GV16230@one.firstfloor.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120903185030.GV16230@one.firstfloor.org> Sender: linux-kernel-owner@vger.kernel.org To: Andi Kleen Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, James Bottomley List-Id: linux-scsi@vger.kernel.org On 9/3/2012 11:50 AM, Andi Kleen wrote: > gcc 4.8 warns because the memset only clears sizeof(char *) bytes, not > the whole buffer. Use the correct buffer size and clear the whole sense > buffer. > > /backup/lsrc/git/linux-lto-2.6/drivers/scsi/bnx2fc/bnx2fc_io.c: In > function 'bnx2fc_parse_fcp_rsp': > /backup/lsrc/git/linux-lto-2.6/drivers/scsi/bnx2fc/bnx2fc_io.c:1810:41: > warning: argument to 'sizeof' in 'memset' call is the same expression as > the destination; did you mean to provide an explicit length? > [-Wsizeof-pointer-memaccess] > memset(sc_cmd->sense_buffer, 0, sizeof(sc_cmd->sense_buffer)); > ^ > > Signed-off-by: Andi Kleen > > > > diff --git a/drivers/scsi/bnx2fc/bnx2fc_io.c b/drivers/scsi/bnx2fc/bnx2fc_io.c > index 73f231c..8d4626c 100644 > --- a/drivers/scsi/bnx2fc/bnx2fc_io.c > +++ b/drivers/scsi/bnx2fc/bnx2fc_io.c > @@ -1807,7 +1807,7 @@ static void bnx2fc_parse_fcp_rsp(struct bnx2fc_cmd *io_req, > fcp_sns_len = SCSI_SENSE_BUFFERSIZE; > } > > - memset(sc_cmd->sense_buffer, 0, sizeof(sc_cmd->sense_buffer)); > + memset(sc_cmd->sense_buffer, 0, SCSI_SENSE_BUFFERSIZE); > if (fcp_sns_len) > memcpy(sc_cmd->sense_buffer, rq_data, fcp_sns_len); > > Thanks Andi. Looks good to me. Acked-by: Bhanu Prakash Gollapudi