From: "Gaëtan Carlier" <gcembed@gmail.com>
To: Fabio Estevam <fabio.estevam@freescale.com>
Cc: philippe.retornaz@epfl.ch, alsa-devel@alsa-project.org,
broonie@opensource.wolfsonmicro.com, kernel@pengutronix.de
Subject: Re: [PATCH] ASoC: mc13783: Remove mono support
Date: Tue, 04 Sep 2012 09:10:13 +0200 [thread overview]
Message-ID: <5045A955.9040606@gmail.com> (raw)
In-Reply-To: <1346688253-29047-1-git-send-email-fabio.estevam@freescale.com>
Hi,
On 09/03/2012 06:04 PM, Fabio Estevam wrote:
> Playing a mono track on a mc13783 codec results in incorrect playback rate.
>
> Remove mono support so that a mono track can be played correctly.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> sound/soc/codecs/mc13783.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/sound/soc/codecs/mc13783.c b/sound/soc/codecs/mc13783.c
> index 8f726c0..115a403 100644
> --- a/sound/soc/codecs/mc13783.c
> +++ b/sound/soc/codecs/mc13783.c
> @@ -659,7 +659,7 @@ static struct snd_soc_dai_driver mc13783_dai_async[] = {
> .id = MC13783_ID_STEREO_DAC,
> .playback = {
> .stream_name = "Playback",
> - .channels_min = 1,
> + .channels_min = 2,
> .channels_max = 2,
> .rates = SNDRV_PCM_RATE_8000_96000,
> .formats = MC13783_FORMATS,
> @@ -670,7 +670,7 @@ static struct snd_soc_dai_driver mc13783_dai_async[] = {
> .id = MC13783_ID_STEREO_CODEC,
> .capture = {
> .stream_name = "Capture",
> - .channels_min = 1,
> + .channels_min = 2,
> .channels_max = 2,
> .rates = MC13783_RATES_RECORD,
> .formats = MC13783_FORMATS,
> @@ -692,14 +692,14 @@ static struct snd_soc_dai_driver mc13783_dai_sync[] = {
> .id = MC13783_ID_SYNC,
> .playback = {
> .stream_name = "Playback",
> - .channels_min = 1,
> + .channels_min = 2,
> .channels_max = 2,
> .rates = SNDRV_PCM_RATE_8000_96000,
> .formats = MC13783_FORMATS,
> },
> .capture = {
> .stream_name = "Capture",
> - .channels_min = 1,
> + .channels_min = 2,
> .channels_max = 2,
> .rates = MC13783_RATES_RECORD,
> .formats = MC13783_FORMATS,
>
On imx27_3ds board:
Tested-by: Gaëtan Carlier <gcembed@gmail.com>
Regards,
Gaëtan Carlier
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next parent reply other threads:[~2012-09-04 7:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1346688253-29047-1-git-send-email-fabio.estevam@freescale.com>
2012-09-04 7:10 ` Gaëtan Carlier [this message]
2012-09-06 0:17 ` [PATCH] ASoC: mc13783: Remove mono support Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5045A955.9040606@gmail.com \
--to=gcembed@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=fabio.estevam@freescale.com \
--cc=kernel@pengutronix.de \
--cc=philippe.retornaz@epfl.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.