From mboxrd@z Thu Jan 1 00:00:00 1970 From: Glauber Costa Subject: Re: [PATCH v2] memcg: first step towards hierarchical controller Date: Tue, 4 Sep 2012 18:54:08 +0400 Message-ID: <50461610.30305@parallels.com> References: <1346687211-31848-1-git-send-email-glommer@parallels.com> <20120903170806.GA21682@dhcp22.suse.cz> <5045BD25.10301@parallels.com> <20120904130905.GA15683@dhcp22.suse.cz> <504601B8.2050907@parallels.com> <20120904143552.GB15683@dhcp22.suse.cz> <50461241.5010300@parallels.com> <20120904145414.GC15683@dhcp22.suse.cz> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20120904145414.GC15683-2MMpYkNvuYDjFM9bn6wA6Q@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Michal Hocko Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, Dave Jones , Ben Hutchings , Peter Zijlstra , Paul Turner , Lennart Poettering , Kay Sievers , Kamezawa Hiroyuki , Johannes Weiner , Tejun Heo >> I believe it would be really great to have a way to turn the default >> to 1 - and stop the shouting. > > We already can. You can use /etc/cgconfig (if you are using libcgroup) > or do it manually. > >> Even if you are doing it in OpenSUSE as a patch, an upstream patch means >> at least that every distribution is using the same patch, and those who >> rebase will just flip the config. >> >> I'd personally believe merging both our patches together would achieve a >> good result. > > I am still not sure we want to add a config option for something that is > meant to go away. But let's see what others think. > So what you propose in the end is that we add a userspace tweak for something that could go away, instead of a Kconfig for something that go away. Way I see it, Kconfig is better because it is totally transparent, under the hood, and will give us a single location to unpatch in case/when it really goes away. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx153.postini.com [74.125.245.153]) by kanga.kvack.org (Postfix) with SMTP id 628E06B005D for ; Tue, 4 Sep 2012 10:57:32 -0400 (EDT) Message-ID: <50461610.30305@parallels.com> Date: Tue, 4 Sep 2012 18:54:08 +0400 From: Glauber Costa MIME-Version: 1.0 Subject: Re: [PATCH v2] memcg: first step towards hierarchical controller References: <1346687211-31848-1-git-send-email-glommer@parallels.com> <20120903170806.GA21682@dhcp22.suse.cz> <5045BD25.10301@parallels.com> <20120904130905.GA15683@dhcp22.suse.cz> <504601B8.2050907@parallels.com> <20120904143552.GB15683@dhcp22.suse.cz> <50461241.5010300@parallels.com> <20120904145414.GC15683@dhcp22.suse.cz> In-Reply-To: <20120904145414.GC15683@dhcp22.suse.cz> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Dave Jones , Ben Hutchings , Peter Zijlstra , Paul Turner , Lennart Poettering , Kay Sievers , Kamezawa Hiroyuki , Johannes Weiner , Tejun Heo >> I believe it would be really great to have a way to turn the default >> to 1 - and stop the shouting. > > We already can. You can use /etc/cgconfig (if you are using libcgroup) > or do it manually. > >> Even if you are doing it in OpenSUSE as a patch, an upstream patch means >> at least that every distribution is using the same patch, and those who >> rebase will just flip the config. >> >> I'd personally believe merging both our patches together would achieve a >> good result. > > I am still not sure we want to add a config option for something that is > meant to go away. But let's see what others think. > So what you propose in the end is that we add a userspace tweak for something that could go away, instead of a Kconfig for something that go away. Way I see it, Kconfig is better because it is totally transparent, under the hood, and will give us a single location to unpatch in case/when it really goes away. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757353Ab2IDO53 (ORCPT ); Tue, 4 Sep 2012 10:57:29 -0400 Received: from mx2.parallels.com ([64.131.90.16]:46622 "EHLO mx2.parallels.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753192Ab2IDO52 (ORCPT ); Tue, 4 Sep 2012 10:57:28 -0400 Message-ID: <50461610.30305@parallels.com> Date: Tue, 4 Sep 2012 18:54:08 +0400 From: Glauber Costa User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120828 Thunderbird/15.0 MIME-Version: 1.0 To: Michal Hocko CC: , , , Dave Jones , Ben Hutchings , Peter Zijlstra , Paul Turner , Lennart Poettering , Kay Sievers , Kamezawa Hiroyuki , Johannes Weiner , Tejun Heo Subject: Re: [PATCH v2] memcg: first step towards hierarchical controller References: <1346687211-31848-1-git-send-email-glommer@parallels.com> <20120903170806.GA21682@dhcp22.suse.cz> <5045BD25.10301@parallels.com> <20120904130905.GA15683@dhcp22.suse.cz> <504601B8.2050907@parallels.com> <20120904143552.GB15683@dhcp22.suse.cz> <50461241.5010300@parallels.com> <20120904145414.GC15683@dhcp22.suse.cz> In-Reply-To: <20120904145414.GC15683@dhcp22.suse.cz> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> I believe it would be really great to have a way to turn the default >> to 1 - and stop the shouting. > > We already can. You can use /etc/cgconfig (if you are using libcgroup) > or do it manually. > >> Even if you are doing it in OpenSUSE as a patch, an upstream patch means >> at least that every distribution is using the same patch, and those who >> rebase will just flip the config. >> >> I'd personally believe merging both our patches together would achieve a >> good result. > > I am still not sure we want to add a config option for something that is > meant to go away. But let's see what others think. > So what you propose in the end is that we add a userspace tweak for something that could go away, instead of a Kconfig for something that go away. Way I see it, Kconfig is better because it is totally transparent, under the hood, and will give us a single location to unpatch in case/when it really goes away.