From: David Vrabel <david.vrabel@citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Stefano Panella <stefano.panella@citrix.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [Xen-devel] [PATCH 1/1] XEN: Use correct masking in xen_swiotlb_alloc_coherent.
Date: Tue, 4 Sep 2012 15:55:16 +0100 [thread overview]
Message-ID: <50461654.5040901@citrix.com> (raw)
In-Reply-To: <20120904143731.GC23361@phenom.dumpdata.com>
On 04/09/12 15:37, Konrad Rzeszutek Wilk wrote:
> On Tue, Sep 04, 2012 at 03:07:42PM +0100, Stefano Panella wrote:
>>
>> So if hwdev->coherent_dma_mask is set to 0xffffffffffffffff our dma_mask will
>> be u64 set to 0xffffffffffffffff even if we set it to DMA_BIT_MASK(32) previously.
>
> That is what I was missing. Let me include that in the git commit and also
> put this patch on the stable tree.
Note that this appears to be a work around for a bug in the sound system
or Intel HDA device driver which is incorrectly truncating a dma_addr_t
to a u32. So by ensuring a DMA_BIT_MASK(32) when the dma_addr_t is
truncated it still works.
David
next prev parent reply other threads:[~2012-09-04 14:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-31 9:57 [PATCH 1/1] XEN: Use correct masking in xen_swiotlb_alloc_coherent Stefano Panella
2012-08-31 9:57 ` Stefano Panella
2012-08-31 12:47 ` [Xen-devel] " David Vrabel
2012-08-31 12:47 ` David Vrabel
2012-08-31 16:40 ` Konrad Rzeszutek Wilk
2012-09-04 14:07 ` Stefano Panella
2012-09-04 14:37 ` Konrad Rzeszutek Wilk
2012-09-04 14:55 ` David Vrabel [this message]
2012-09-04 15:12 ` Stefano Panella
2012-09-04 16:44 ` David Vrabel
2012-09-04 16:40 ` Konrad Rzeszutek Wilk
2012-09-05 13:13 ` Stefano Panella
2012-09-05 14:33 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50461654.5040901@citrix.com \
--to=david.vrabel@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stefano.panella@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.