From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH v2] add acpi pmtimer support Date: Tue, 04 Sep 2012 19:28:49 +0300 Message-ID: <50462C41.5010602@redhat.com> References: <1344922159-22703-1-git-send-email-kraxel@redhat.com> <20120902204243.GC1814@morn.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Gerd Hoffmann , seabios@seabios.org, kvm@vger.kernel.org To: "Kevin O'Connor" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:15683 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932218Ab2IDQ3N (ORCPT ); Tue, 4 Sep 2012 12:29:13 -0400 In-Reply-To: <20120902204243.GC1814@morn.localdomain> Sender: kvm-owner@vger.kernel.org List-ID: On 09/02/2012 11:42 PM, Kevin O'Connor wrote: > On Tue, Aug 14, 2012 at 07:29:19AM +0200, Gerd Hoffmann wrote: >> This patch makes seabios use the acpi pmtimer instead of tsc for >> timekeeping. The pmtimer has a fixed frequency and doesn't need >> calibration, thus it doesn't suffer from calibration errors due to a >> loaded host machine. > > The patch looks okay to me, but is it still needed? (I recall seeing > something on the kvm list about a bug fix to the main timer.) Timing will always be fragile in a vm, so I think this can make things more robust. -- error compiling committee.c: too many arguments to function